Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cdk-nag suppressions in addition to cfn-nag #1180

Open
1 task done
joshwand opened this issue Aug 26, 2024 · 1 comment
Open
1 task done

Add cdk-nag suppressions in addition to cfn-nag #1180

joshwand opened this issue Aug 26, 2024 · 1 comment
Labels
feature-request A feature should be added or improved needs-triage The issue or PR still needs to be triaged

Comments

@joshwand
Copy link

There are dozens of core helpers that generate cfnRulesToSuppress, but that project has been abandoned, and there is now the officially-AWS-supported cdk-nag project.

All aws-solutions-constructs should comply with cdk-nag rules, or add appropriate cdk-nag suppressions.

Use Case

aws-solutions-constructs should follow security best practices.

  • ⚠️ This feature might incur a breaking change

This is a 🚀 Feature Request

@joshwand joshwand added feature-request A feature should be added or improved needs-triage The issue or PR still needs to be triaged labels Aug 26, 2024
@biffgaut
Copy link
Contributor

biffgaut commented Aug 26, 2024

We agree cfn-nag appears to be dormant, as the most recent release was 2 years ago. Rather than cdk-nag we have replaced it in our build pipeline with Cloudformation Guard with pretty good success. We've added suppression statements for this tool and this ruleset. Our internal tooling has altered the rules to enable cfn-nag suppressions to suppress CloudFormation Guard rules as well - so we may need to go back and confirm that all the suppressions work if someone is using the raw ruleset from github.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request A feature should be added or improved needs-triage The issue or PR still needs to be triaged
Projects
None yet
Development

No branches or pull requests

4 participants
@joshwand @biffgaut and others