Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Make IoT and KinesisStreams Constructs Consistent): Update IoT and KinesisStreams constructs to match DESIGN_GUIDELINES.md #388

Open
2 tasks
biffgaut opened this issue Sep 20, 2021 · 0 comments
Labels
feature-request A feature should be added or improved needs-triage The issue or PR still needs to be triaged

Comments

@biffgaut
Copy link
Contributor

DESIGN_GUIDELINES.md has been updated to reflect some additional Props and Properties that had been implemented on some constructs but were not consistent.

We need to align all the iot and kinesisstreams constructs with the current DESIGN_GUIDELINES.md, including, but not necessarily limited to:

Kinesis Streams
createCloudWatchAlarms
cloudWatchAlarms

Iot
iotTopicRule (as a property)

Use Case

Proposed Solution

Other

  • 👋 I may be able to implement this feature request
  • ⚠️ This feature might incur a breaking change

This is a 🚀 Feature Request

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request A feature should be added or improved needs-triage The issue or PR still needs to be triaged
Projects
None yet
Development

No branches or pull requests

1 participant