Skip to content

Not triggering on links anymore. #46

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
agzam opened this issue May 31, 2022 · 8 comments · Fixed by #48
Closed

Not triggering on links anymore. #46

agzam opened this issue May 31, 2022 · 8 comments · Fixed by #48

Comments

@agzam
Copy link

agzam commented May 31, 2022

For some reason it stopped working for links and I can't figure out why. What's the best method of debugging this?

I'm trying to eval (org-appear-manual-start) while cursor at the link, it reports returning t, but nothing is happening.

I tried funneling things through the Profiler (simply moving cursor in and out, around the square brackets of a link), it shows org-appear--post-cmd, but perhaps, it doesn't seem to trigger some preliminary function. Is that right?

33,282   1% - org-appear--post-cmd
32,258   1%  - org-appear--current-elem
32,258   1%   - org-element-context
19,648   0%    - org-element-at-point
19,648   0%     - org-element--parse-to
 8,384   0%        org-element-headline-parser
 7,600   0%    - org-element--object-lex
 7,600   0%     - org-element-link-parser
 1,024   0%        org-link-unescape

Testing it the same way with "bold" elements appears to run org-appear--show:

10,704   0%   - org-appear--show-with-lock
10,704   0%    - org-appear--current-elem
10,704   0%     - org-element-context
10,704   0%      - org-element--object-lex
10,704   0%       - org-element-bold-parser
10,704   0%        - org-element--parse-generic-emphasis
10,704   0%         - rx-to-string
10,704   0%          - rx--translate
10,704   0%           - rx--translate-form
10,704   0%            - rx--translate-seq
10,704   0%             - rx--translate
10,704   0%              - rx--translate-form
10,452   0%               + rx--translate-or
252      0%               - rx--translate-not
252      0%                  rx--generate-alt

And it works with bold elements as before. Why it's no longer working for links? Can't figure it out.

@awth13
Copy link
Owner

awth13 commented Jun 5, 2022

Hi, @agzam! Thank you for posting the issue!

What is your Org and Emacs version? I suspect this issue might be related to #5 -- you can check if your Org version has org-fold merged by evaluating (featurep 'org-fold).

@artelse
Copy link

artelse commented Jun 6, 2022

Am having the same problem with links not expanding. I run Emacs 29 master and org 9.5.4 and org-fold is present (of course).

@agzam
Copy link
Author

agzam commented Jun 6, 2022

Mine is Org mode version 9.6 (9.6-??-7c51329), running on GNU Emacs 29.0.50 (build 2, x86_64-apple-darwin21.5.0, NS appkit-2113.50 Version 12.4 (Build 21F79)) of 2022-06-05

@awth13
Copy link
Owner

awth13 commented Jun 18, 2022

Thank you again, @agzam and @artelse, for the input! The issue is now fixed.

@artelse
Copy link

artelse commented Jun 18, 2022

Tested, fixed, thx!

@agzam
Copy link
Author

agzam commented Jun 19, 2022

@awth13 Thank you for fixing it promptly. I discovered 'org-appear' a long time ago, thought: "wow, this is cool", added it to my config and quickly forgot about it.

The most efficient software is like a killer move in the martial arts - the deadliest blows cannot be seen with a naked eye, things happen in an instance - there's nothing cinematic or cool about the fight.

That's what I felt using 'org-appear'. It has become part of my daily workflow. It's been great and worked almost undetected. Until one day it stopped working. And then I felt miserable. I realized how much I've become accustomed to the tiny feature of gracefully hiding and revealing things. Thank you for this gift. Thank you for giving me (and many others) the power of being an Org-mode ninja.

@awth13
Copy link
Owner

awth13 commented Jun 25, 2022

Thank you for the kind words, @agzam! I'm glad you enjoy using org-appear :)

@timmli
Copy link

timmli commented Jan 13, 2023

It seems that this issue has reappeared in Org v9.6.1 :-(

Anyone having the same experience?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants