fix: cached isArray

Author: AndyOGo

src/createJsonLogic.js

@@ -1,3 +1,4 @@
+import isArray from './helpers/isArray';
 import isLogic from './helpers/isLogic';
 import getOperator from './helpers/getOperator';
 
@@ -23,15 +24,15 @@ function createJsonLogic(operations = {}, visitors = {}) {
   }
 
   function addVisitor(name, code) {
-    if (Array.isArray(name)) {
+    if (isArray(name)) {
       name.forEach(addVisitor);
     }
 
     visitors[name] = code;
   }
 
   function removeVisitor(name) {
-    if (Array.isArray(name)) {
+    if (isArray(name)) {
       name.forEach(removeVisitor);
     }
 
@@ -40,7 +41,7 @@ function createJsonLogic(operations = {}, visitors = {}) {
 
   function apply(logic, data) {
     // Does this array contain logic? Only one way to find out.
-    if(Array.isArray(logic)) {
+    if(isArray(logic)) {
       return logic.map(function(l) {
         return apply(l, data);
       });
@@ -57,7 +58,7 @@ function createJsonLogic(operations = {}, visitors = {}) {
     let i;
 
     // easy syntax for unary operators, like {"var" : "x"} instead of strict {"var" : ["x"]}
-    if( ! Array.isArray(values)) {
+    if( ! isArray(values)) {
       values = [values];
     }
 

src/helpers/isArray.js

@@ -0,0 +1 @@
+export default Array.isArray;

src/helpers/isLogic.js

@@ -1,8 +1,10 @@
+import isArray from './isArray';
+
 function isLogic(logic) {
   return (
     typeof logic === "object" && // An object
     logic !== null && // but not null
-    !Array.isArray(logic) && // and not an array
+    !isArray(logic) && // and not an array
     Object.keys(logic).length === 1 // with exactly one key
   );
 }

src/helpers/ruleLike.js

@@ -1,3 +1,4 @@
+import isArray from './isArray';
 import isLogic from './isLogic';
 import getOperator from './getOperator';
 import getValues from './getValues';
@@ -18,7 +19,7 @@ function ruleLike(rule, pattern) {
   }
   if(pattern === "array") {
     // !logic test might be superfluous in JavaScript
-    return Array.isArray(rule) && ! isLogic(rule);
+    return isArray(rule) && ! isLogic(rule);
   }
 
   if(isLogic(pattern)) {
@@ -37,8 +38,8 @@ function ruleLike(rule, pattern) {
     return false; // pattern is logic, rule isn't, can't be eq
   }
 
-  if(Array.isArray(pattern)) {
-    if(Array.isArray(rule)) {
+  if(isArray(pattern)) {
+    if(isArray(rule)) {
       if(pattern.length !== rule.length) {
         return false;
       }

src/helpers/truthy.js

@@ -1,10 +1,12 @@
+import isArray from './isArray';
+
 /*
   This helper will defer to the JsonLogic spec as a tie-breaker when different language interpreters define different behavior for the truthiness of primitives.  E.g., PHP considers empty arrays to be falsy, but Javascript considers them to be truthy. JsonLogic, as an ecosystem, needs one consistent answer.
 
   Spec and rationale here: http://jsonlogic.com/truthy
   */
 function truthy(a) {
-  if(Array.isArray(value) && value.length === 0) {
+  if(isArray(value) && value.length === 0) {
     return false;
   }
 

src/helpers/usesData.js

@@ -1,3 +1,4 @@
+import isArray from './isArray';
 import isLogic from './isLogic';
 import getOperator from './getOperator';
 import arrayUnique from './arrayUnique';
@@ -9,7 +10,7 @@ function usesData(logic) {
     var op = getOperator(logic);
     var values = logic[op];
 
-    if( ! Array.isArray(values)) {
+    if( ! isArray(values)) {
       values = [values];
     }
 

src/index.js

@@ -1,4 +1,4 @@
-export createJsonLogic from './createJsonLogic';
+import createJsonLogic from './createJsonLogic';
 import * as operations from './operations';
 import * as visitors from './visitors';
 import isLogic from "./helpers/isLogic";

src/operations/accessor/missing.js

@@ -1,3 +1,4 @@
+import isArray from '../../helpers/isArray';
 import variable from './variable'
 
 function missing() {
@@ -9,7 +10,7 @@ function missing() {
   */
 
   var missing = [];
-  var keys = Array.isArray(arguments[0]) ? arguments[0] : arguments;
+  var keys = isArray(arguments[0]) ? arguments[0] : arguments;
 
   for(var i = 0; i < keys.length; i++) {
     var key = keys[i];

src/visitors/array/filter.js

@@ -1,10 +1,11 @@
+import isArray from '../../helpers/isArray';
 import truthy from "../../helpers/truthy";
 
 function filter(apply, data, values) {
   const scopedData = apply(values[0], data);
   const scopedLogic = values[1];
 
-  if ( ! Array.isArray(scopedData)) {
+  if ( ! isArray(scopedData)) {
     return [];
   }
   // Return only the elements from the array in the first argument,

src/visitors/array/map.js

@@ -1,8 +1,10 @@
+import isArray from '../../helpers/isArray';
+
 function map(apply, data, values) {
   const scopedData = apply(values[0], data);
   const scopedLogic = values[1];
 
-  if ( ! Array.isArray(scopedData)) {
+  if ( ! isArray(scopedData)) {
     return [];
   }