Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not return unpublished destinations IDs on related events from API #1044

Open
flibbertigibbet opened this issue May 16, 2018 · 0 comments

Comments

@flibbertigibbet
Copy link
Contributor

For JSON destination results from the search API endpoint (and any other endpoints that may return events as JSON), check if the related destination is published, and omit its ID from the response if not.

This is to address an issue where the Android app crashes because the related destination cannot be found (only published destinations are returned).

Also, it would be good to ensure the drop-down for associating an event with a destination only displays published destinations as options, although that will be insufficient to protect against the destination getting unpublished later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant