Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Image paths in JSON should always include host #1046

Open
flibbertigibbet opened this issue May 21, 2018 · 1 comment
Open

Image paths in JSON should always include host #1046

flibbertigibbet opened this issue May 21, 2018 · 1 comment
Labels
Technical Debt

Comments

@flibbertigibbet
Copy link
Contributor

In development, image paths from the /api/destinations/search endpoint currently come back as relative paths. Although this seems to not have broken anything on the site in development, the production site currently returns full URLs, and also has an image host (on S3) that differs from the site host.

URLs returned in JSON should be absolute, as the host is ambiguous, and for consistency with the previous JSON response.
@flibbertigibbet flibbertigibbet mentioned this issue May 21, 2018
Closed
@flibbertigibbet
Copy link
Contributor Author

Current master branch also returns relative paths locally, so this is only in the development environment.

@flibbertigibbet flibbertigibbet mentioned this issue Jun 5, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Technical Debt
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@flibbertigibbet