Skip to content

Commit 39ac3b8

Browse files
authored
Followup #159: Further tweaking of JS for jQuery and Backdrop.
By @laryn and @herbdool.
1 parent dc728a8 commit 39ac3b8

File tree

2 files changed

+9
-9
lines changed

2 files changed

+9
-9
lines changed

dist/js/description_toggle.js

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,14 +1,14 @@
11
(Backdrop => {
22
Backdrop.behaviors.formDescriptionToggle = {
33
attach: function(context, settings) {
4-
context[0].querySelectorAll(".help-icon__description-toggle").forEach(((elem, index) => {
5-
if (elem.dataset.formDescriptionToggleAttached) return;
6-
elem.dataset.formDescriptionToggleAttached = !0;
4+
$(".help-icon__description-toggle", context).once("formDescriptionToggle").each((function() {
5+
if (this.dataset.formDescriptionToggleAttached) return;
6+
this.dataset.formDescriptionToggleAttached = !0;
77
const a11yLabel = "help-icon-label--" + Math.floor(1e4 * Math.random());
8-
elem.setAttribute("id", a11yLabel), elem.setAttribute("aria-expanded", "false"),
9-
elem.setAttribute("aria-controls", "target"), elem.closest(".help-icon__description-container").querySelectorAll(".description").forEach((description => {
8+
this.setAttribute("id", a11yLabel), this.setAttribute("aria-expanded", "false"),
9+
this.setAttribute("aria-controls", "target"), this.closest(".help-icon__description-container").querySelectorAll(".description").forEach((description => {
1010
description.setAttribute("aria-labelledby", a11yLabel);
11-
})), elem.addEventListener("click", (event => {
11+
})), this.addEventListener("click", (event => {
1212
event.preventDefault(), event.stopPropagation(), "SUMMARY" === event.currentTarget.parentElement.tagName && !1 === event.currentTarget.parentElement.parentElement.open && (event.currentTarget.parentElement.parentElement.open = !0),
1313
event.currentTarget.focus(), event.currentTarget.closest(".help-icon__description-container").querySelectorAll(".description").forEach(((description, index) => {
1414
if (index > 1) return;

js/description_toggle.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,9 @@
11
((Backdrop) => {
22
Backdrop.behaviors.formDescriptionToggle = {
33
attach: function (context, settings) {
4-
context[0]
5-
.querySelectorAll('.help-icon__description-toggle')
6-
.forEach((elem, index) => {
4+
$('.help-icon__description-toggle', context).once('formDescriptionToggle')
5+
.each(function() {
6+
let elem = this;
77
if (elem.dataset.formDescriptionToggleAttached) {
88
return;
99
}

0 commit comments

Comments
 (0)