-
Notifications
You must be signed in to change notification settings - Fork 514
[BREAKING] Consolidate all create, edit, and delete functionality into the unified AdminPortal #6273
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Missing ChangesetsThe following package(s) are changed by this PR but do not have a changeset:
See CONTRIBUTING.md for more information about how to add changesets. Changed Packages
|
20ceb07 to
9085945
Compare
Removes all individual pages for creating and edits announcements, categories, and tags. Users must use the admin portal component in order to manage announcements, categories, and tags. Signed-off-by: Kurt King <[email protected]>
9085945 to
7492b3a
Compare
Signed-off-by: Kurt King <[email protected]>
|
Thanks for the contribution! |
This reverts commit 7b557c2. Signed-off-by: Kurt King <[email protected]>
Signed-off-by: Kurt King <[email protected]>
dfe8593 to
9186480
Compare
|
I think this is the right way forward 👍 |
|
I've just realized we don't support editing an announcement via the admin portal. Will need to knock that out before we can move forward with this. |
gaelgoth
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! I played with it a bit locally and didn’t encounter any issues 👍🏾
There is still a small cleanup to do in the translation file, where you can remove announcementsPage.contextMenu.tags and announcementsPage.contextMenu.categorie.
Why not take this opportunity to change announcementsPage.contextMenu.admin to "Manage Announcements" instead of "Admin"?
…into deprecate-individual-manage-pages
Very nice catch on the translations file and I'm good with Manage Announcements. Changes made in e42da02. |
Signed-off-by: Kurt King <[email protected]>
e42da02 to
2b872ca
Compare
Signed-off-by: Kurt King <[email protected]>
Hey, I just made a Pull Request!
We are consolidating all functionality into the admin portal. The previous version provides individual pages for each of these entry points which have now been removed.
As the plugin's adoption grew, more requests to hide UI components based on permissions came in. This decision was made to simplify the plugin and reduce the complexity of the codebase. It also provides a more consistent UX for admin operations and allows for more flexibility in the future.
Review the changeset for a complete breakdown of changes in the PR.
Reduction (with more to come)
are changesets include in the +119? 👀
Screenshots
Renamed Admin to Manage announcements and removed Categories and Tags
Complete UI example for admin portal
Manage categories (and tags) via admin portal
✔️ Checklist
Signed-off-byline in the message. (more info)