Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

♿ a11y(Bal-nav): Open A11y Issues #1621

Open
1 task done
GinaBiondo-aperto opened this issue Feb 19, 2025 · 6 comments · May be fixed by #1625
Open
1 task done

♿ a11y(Bal-nav): Open A11y Issues #1621

GinaBiondo-aperto opened this issue Feb 19, 2025 · 6 comments · May be fixed by #1625
Assignees
Labels
✨ feature New feature or request

Comments

@GinaBiondo-aperto
Copy link
Collaborator

Description of this issue

The following accessibility issues are still open.

  1. Meta Nav

    • the nav has a role="tablist" hence the nav is not announced as navigation
    • links should be in a list (ul > li)
    • there should be aria-labels on the nav tags to distinguish between "meta", "main" and "sub" navigations
  2. Main nav

    • when the flyout is opened, the first element inside should be in focus
  3. Meta Nav Popups

    • users are currently stuck in the popup , when navigating via Screenreader (Keyboard) to a button, link, input field.

How to fix it

See above

Code Reproduction URL

https://www.baloise.ch/de/privatkunden.html

Additional Information

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct
@GinaBiondo-aperto GinaBiondo-aperto added the ✨ feature New feature or request label Feb 19, 2025
@mmarinkov
Copy link
Contributor

  1. Meta Nav

    • the nav has a role="tablist" hence the nav is not announced as navigation = will check
    • links should be in a list (ul > li) = will check
    • there should be aria-labels on the nav tags to distinguish between "meta", "main" and "sub" navigations
      • i guess the labels are not understandable by the users, moreover we need all the tranlstions for them
  2. Main nav

    • when the flyout is opened, the first element inside should be in focus
      • all tabs are workling the same way, we should not change the behaviour of one case
  3. Meta Nav Popups

    • users are currently stuck in the popup , when navigating via Screenreader (Keyboard) to a button, link, input field.
      • user can navigate with the keyboard to the close element on the top right or even just click escape

@carolabes
Copy link

Hi @mmarinkov,

  1. Meta Nav
    we can use translation keys for the aria-label, but first we need to know, if those aria-labels already exists or need to be added by you.

  2. main nav
    Since the main nav is a core feature of the page, it requires a high level of accessibility. So the focus order needs to be correct and mouse operation should equal key operation. Therefore we should think of adding this case or find an alternative to provide this functionality.

  3. Meta nav popup
    This is a voiceOver Screenreader issue only. I tested this on macOS, voiceOver, Chrome. The user can't navigate back to the close button once the focus is on a link or button. This is especially an issue for the search popup since there is a tab componenten below the button which the screenreader user can never reach. It would be great if you could find a fix for this.

@hirsch88
Copy link
Member

  1. is a standard safari behaviour. when enabling the options it works

Image

@hirsch88
Copy link
Member

/cib

Copy link
Contributor

Branch feat/issue-1621 created!

github-actions bot added a commit that referenced this issue Feb 20, 2025
@github-actions github-actions bot linked a pull request Feb 20, 2025 that will close this issue
@mmarinkov
Copy link
Contributor

mmarinkov commented Feb 21, 2025

Summary ticket

  1. Has been implemented the only part missing is:
  • the right naming conventions and translations for the meta/mai nav from IBM
  1. Focus in Flyout
  1. Is a standard safari behaviour. when enabling the options it works

@mmarinkov mmarinkov self-assigned this Feb 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✨ feature New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants