Fix words variable environment leak (#73)

h3xx · web-flow · commit 83705bedfb32 · 2022-12-18T21:09:07.000+01:00
After tab-completing, the `$words` array would persist and possibly
affect other things.

Using `local` keeps it inside the function scope.
diff --git a/resources/bash/cached.php b/resources/bash/cached.php
@@ -1,6 +1,6 @@
 _<?php echo $vars['script'] ?>()
 {
-    local cur script coms opts com
+    local cur script coms opts com words
     COMPREPLY=()
     _get_comp_words_by_ref -n : cur words
 
diff --git a/resources/bash/default.php b/resources/bash/default.php
@@ -1,6 +1,6 @@
 _symfony()
 {
-    local cur script com opts
+    local cur script com opts words
     COMPREPLY=()
     _get_comp_words_by_ref -n : cur words
 
diff --git a/tests/fixtures/bash/cached.txt b/tests/fixtures/bash/cached.txt
@@ -1,6 +1,6 @@
 _acme()
 {
-    local cur script coms opts com
+    local cur script coms opts com words
     COMPREPLY=()
     _get_comp_words_by_ref -n : cur words
 
diff --git a/tests/fixtures/bash/default.txt b/tests/fixtures/bash/default.txt
@@ -1,6 +1,6 @@
 _symfony()
 {
-    local cur script com opts
+    local cur script com opts words
     COMPREPLY=()
     _get_comp_words_by_ref -n : cur words
 

Original file line number	Diff line number	Diff line change
`@@ -1,6 +1,6 @@`
`1`	`1`	`_<?php echo $vars['script'] ?>()`
`2`	`2`	`{`
`3`		`- local cur script coms opts com`
	`3`	`+ local cur script coms opts com words`
`4`	`4`	`COMPREPLY=()`
`5`	`5`	`_get_comp_words_by_ref -n : cur words`
`6`	`6`
Original file line number	Diff line number	Diff line change
`@@ -1,6 +1,6 @@`
`1`	`1`	`_symfony()`
`2`	`2`	`{`
`3`		`- local cur script com opts`
	`3`	`+ local cur script com opts words`
`4`	`4`	`COMPREPLY=()`
`5`	`5`	`_get_comp_words_by_ref -n : cur words`
`6`	`6`
Original file line number	Diff line number	Diff line change
`@@ -1,6 +1,6 @@`
`1`	`1`	`_acme()`
`2`	`2`	`{`
`3`		`- local cur script coms opts com`
	`3`	`+ local cur script coms opts com words`
`4`	`4`	`COMPREPLY=()`
`5`	`5`	`_get_comp_words_by_ref -n : cur words`
`6`	`6`