refactor: REPLIES => REPLY_QUERYTREE. Closes #13

The name is much more descriptive and since the function setting
`REPLY_QUERYTREE` is internal, its OK

Author: hyperupcall

bake

@@ -5,7 +5,7 @@
 # @exitcode 1 Miscellaneous error
 # @exitcode 2 Parsing error
 bash_object.parse_querytree() {
-	declare -ga REPLIES=()
+	declare -ga REPLY_QUERYTREE=()
 
 	local flag_parser_type=
 
@@ -33,7 +33,7 @@ bash_object.parse_querytree() {
 				continue
 			fi
 
-			REPLIES+=("$key")
+			REPLY_QUERYTREE+=("$key")
 		done
 		IFS="$old_ifs"
 	elif [ "$flag_parser_type" = 'advanced' ]; then
@@ -112,7 +112,7 @@ bash_object.parse_querytree() {
 						return
 					fi
 
-					REPLIES+=("$reply")
+					REPLY_QUERYTREE+=("$reply")
 					mode='MODE_EXPECTING_CLOSING_BRACKET'
 				elif [ "$char" = $'\n' ]; then
 					bash_object.util.die 'ERROR_QUERYTREE_INVALID' 'Querytree is not complete'
@@ -135,7 +135,7 @@ bash_object.parse_querytree() {
 				;;
 			MODE_EXPECTING_READ_NUMBER)
 				if [ "$char" = ']' ]; then
-					REPLIES+=("$reply")
+					REPLY_QUERYTREE+=("$reply")
 					mode='MODE_BEFORE_DOT'
 				else
 					case "$char" in

pkg/src/parse.sh

@@ -78,8 +78,8 @@ bash_object.traverse-get() {
 		*) bash_object.parse_querytree --simple "$querytree" ;;
 	esac
 	local i=
-	for ((i=0; i<${#REPLIES[@]}; i++)); do
-		local key="${REPLIES[$i]}"
+	for ((i=0; i<${#REPLY_QUERYTREE[@]}; i++)); do
+		local key="${REPLY_QUERYTREE[$i]}"
 
 		local is_index_of_array='no'
 		if [ "${key::1}" = $'\x1C' ]; then
@@ -163,11 +163,11 @@ bash_object.traverse-get() {
 					return
 				fi
 
-				if ((i+1 < ${#REPLIES[@]})); then
+				if ((i+1 < ${#REPLY_QUERYTREE[@]})); then
 					# Do nothing, and continue to next element in query. We already check for the
 					# validity of the virtual object above, so no need to do anything here
 					:
-				elif ((i+1 == ${#REPLIES[@]})); then
+				elif ((i+1 == ${#REPLY_QUERYTREE[@]})); then
 					# We are last element of query, return the object
 					if [ "$final_value_type" = object ]; then
 						case "$vmd_dtype" in
@@ -245,10 +245,10 @@ bash_object.traverse-get() {
 					bash_object.trace_print 2 "BLOCK: STRING"
 				fi
 
-				if ((i+1 < ${#REPLIES[@]})); then
+				if ((i+1 < ${#REPLY_QUERYTREE[@]})); then
 					bash_object.util.die 'ERROR_NOT_FOUND' "The passed querytree implies that '$key' accesses an object or array, but a string with a value of '$key_value' was found instead"
 					return
-				elif ((i+1 == ${#REPLIES[@]})); then
+				elif ((i+1 == ${#REPLY_QUERYTREE[@]})); then
 					local value="${__current_object[$key]}"
 					if [ "$final_value_type" = object ]; then
 						bash_object.util.die 'ERROR_ARGUMENTS_INCORRECT_TYPE' "Queried for $final_value_type, but found existing string '$value'"

pkg/src/traverse-get.sh

@@ -219,8 +219,8 @@ bash_object.traverse-set() {
 		*) bash_object.parse_querytree --simple "$querytree" ;;
 	esac
 	local i=
-	for ((i=0; i<${#REPLIES[@]}; i++)); do
-		local key="${REPLIES[$i]}"
+	for ((i=0; i<${#REPLY_QUERYTREE[@]}; i++)); do
+		local key="${REPLY_QUERYTREE[$i]}"
 
 		local is_index_of_array='no'
 		if [ "${key::1}" = $'\x1C' ]; then
@@ -245,11 +245,11 @@ bash_object.traverse-set() {
 		# If 'key' is not a member of object or index of array, error
 		elif [ -z "${__current_object[$key]+x}" ]; then
 			# If we are before the last element in the query, then error
-			if ((i+1 < ${#REPLIES[@]})); then
+			if ((i+1 < ${#REPLY_QUERYTREE[@]})); then
 				bash_object.util.die 'ERROR_NOT_FOUND' "Key or index '$key' (querytree index '$i') does not exist"
 				return
 			# If we are at the last element in the query, and it doesn't exist, create it
-			elif ((i+1 == ${#REPLIES[@]})); then
+			elif ((i+1 == ${#REPLY_QUERYTREE[@]})); then
 				if [ "$final_value_type" = object ]; then
 					bash_object.util.generate_vobject_name "$root_object_name" "$querytree_stack_string"
 					local global_object_name="$REPLY"
@@ -360,11 +360,11 @@ bash_object.traverse-set() {
 					return
 				fi
 
-				if ((i+1 < ${#REPLIES[@]})); then
+				if ((i+1 < ${#REPLY_QUERYTREE[@]})); then
 					# Do nothing, and continue to next element in query. We already check for the
 					# validity of the virtual object above, so no need to do anything here
 					:
-				elif ((i+1 == ${#REPLIES[@]})); then
+				elif ((i+1 == ${#REPLY_QUERYTREE[@]})); then
 					# We are last element of query, but do not set the object there is one that already exists
 					if [ "$final_value_type" = object ]; then
 						case "$vmd_dtype" in
@@ -416,10 +416,10 @@ bash_object.traverse-set() {
 					bash_object.trace_print 2 "BLOCK: STRING"
 				fi
 
-				if ((i+1 < ${#REPLIES[@]})); then
+				if ((i+1 < ${#REPLY_QUERYTREE[@]})); then
 					bash_object.util.die 'ERROR_NOT_FOUND' "The passed querytree implies that '$key' accesses an object or array, but a string with a value of '$key_value' was found instead"
 					return
-				elif ((i+1 == ${#REPLIES[@]})); then
+				elif ((i+1 == ${#REPLY_QUERYTREE[@]})); then
 					local value="${__current_object[$key]}"
 					if [ "$final_value_type" = object ]; then
 						bash_object.util.die 'ERROR_ARGUMENTS_INCORRECT_TYPE' "Assigning an $final_value_type, but found existing string '$value'"

pkg/src/traverse-set.sh

@@ -4,7 +4,7 @@ bash_object.trace_loop() {
 	if [ -n "${TRACE_BASH_OBJECT_TRAVERSE+x}" ]; then
 		bash_object.trace_print 0 "-- START LOOP ITERATION"
 		bash_object.trace_print 0 "i+1: '$((i+1))'"
-		bash_object.trace_print 0 "\${#REPLIES[@]}: ${#REPLIES[@]}"
+		bash_object.trace_print 0 "\${#REPLY_QUERYTREE[@]}: ${#REPLY_QUERYTREE[@]}"
 		bash_object.trace_print 0 "key: '$key'"
 		bash_object.trace_print 0 "current_object_name: '$current_object_name'"
 		bash_object.trace_print 0 "current_object=("