Skip to content

Commit 59bbd80

Browse files
allevatobrentleyjones
authored andcommitted
Enable AEGs
(cherry picked from commit 8a4310e) Signed-off-by: Brentley Jones <[email protected]>
1 parent 3dfbf33 commit 59bbd80

File tree

5 files changed

+3
-19
lines changed

5 files changed

+3
-19
lines changed

swift/swift_binary.bzl

Lines changed: 3 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,6 @@
1414

1515
"""Implementation of the `swift_binary` rule."""
1616

17-
load("@bazel_skylib//lib:dicts.bzl", "dicts")
1817
load("@bazel_skylib//lib:paths.bzl", "paths")
1918
load("@rules_cc//cc/common:cc_common.bzl", "cc_common")
2019
load("@rules_cc//cc/common:cc_info.bzl", "CcInfo")
@@ -276,15 +275,9 @@ def _swift_binary_impl(ctx):
276275
return providers
277276

278277
swift_binary = rule(
279-
attrs = dicts.add(
280-
binary_rule_attrs(
281-
additional_deps_providers = [[SwiftCompilerPluginInfo]],
282-
stamp_default = -1,
283-
),
284-
{
285-
# TODO(b/301253335): Enable AEGs and switch from `swift` exec_group to swift `toolchain` param.
286-
"_use_auto_exec_groups": attr.bool(default = False),
287-
},
278+
attrs = binary_rule_attrs(
279+
additional_deps_providers = [[SwiftCompilerPluginInfo]],
280+
stamp_default = -1,
288281
),
289282
doc = """\
290283
Compiles and links Swift code into an executable binary.

swift/swift_compiler_plugin.bzl

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -371,8 +371,6 @@ universal_swift_compiler_plugin = rule(
371371
mandatory = True,
372372
providers = [[SwiftBinaryInfo, SwiftCompilerPluginInfo]],
373373
),
374-
# TODO(b/301253335): Enable AEGs and switch from `swift` exec_group to swift `toolchain` param.
375-
"_use_auto_exec_groups": attr.bool(default = False),
376374
},
377375
),
378376
doc = """\

swift/swift_library.bzl

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -285,9 +285,6 @@ dependent for linking, but artifacts/flags required for compilation (such as
285285
.swiftmodule files, C headers, and search paths) will not be propagated.
286286
""",
287287
),
288-
# TODO(b/301253335): Once AEGs are enabled in Bazel, set the swift toolchain type in the
289-
# exec configuration of `plugins` attribute and enable AEGs in swift_library.
290-
"_use_auto_exec_groups": attr.bool(default = False),
291288
},
292289
),
293290
doc = """\

swift/swift_test.bzl

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -604,8 +604,6 @@ environment when the test is executed by `bazel test`.
604604
Label("//tools/test_observer"),
605605
],
606606
),
607-
# TODO(b/301253335): Enable AEGs and switch from `swift` exec_group to swift `toolchain` param.
608-
"_use_auto_exec_groups": attr.bool(default = False),
609607
},
610608
),
611609
doc = """\

swift/toolchains/xcode_swift_toolchain.bzl

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -993,8 +993,6 @@ for incremental compilation using a persistent mode.
993993
fragment = "apple",
994994
),
995995
),
996-
# TODO(b/301253335): Enable AEGs later.
997-
"_use_auto_exec_groups": attr.bool(default = False),
998996
},
999997
),
1000998
doc = "Represents a Swift compiler toolchain provided by Xcode.",

0 commit comments

Comments
 (0)