-
Notifications
You must be signed in to change notification settings - Fork 144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
1.12.1 + master (91aa4d89): pytest fails #237
Comments
Not sure what's going on, but the code you are using doesn't seem to be the one available from Beaker. You are getting a syntax error from a line of code that doesn't exist in the codebase
As you can see there is no such line of code in https://github.com/bbangert/beaker/blob/1.12.1/beaker/ext/sqla.py |
OK I found what is going on. --- a/beaker/ext/sqla.py
+++ b/beaker/ext/sqla.py
@@ -52,7 +52,7 @@
verify_directory(self.lock_dir)
self.bind = self.__class__.binds.get(str(bind.url), lambda: bind)
- self.table = self.__class__.tables.get('%s:%s' % (bind.url, table.name),
+ self.table = self.__class__.tables.get('{}:{}'.format(bind.url, table.name),
lambda: table)
self.hash = {}
self._is_new = False
@@ -80,9 +80,8 @@
self._is_new = False
try:
self.hash = result.data
- except (IOError, OSError, EOFError, pickle.PickleError,
- pickle.PickleError):
- log.debug("Couln't load pickle data, creating new storage")
+ except (IOError, OSError, EOFError, pickle.PickleError):
+ log.debug OSError
self.hash = {}
self._is_new = True
self.flags = flags I've been preparing to submit PR with drop python<=3.7 support. First part of those modifications was patch generated by pyupgrade. You can play with that by executing command |
It's the second block, where it changes That whole change is nonsensical, in fact, I don't know what went wrong but it's clearly a bug in pyupgrade. The first block is fine. |
Could you please report that but as looks like it would be easier for you what is wrong in this case? 🤔 |
I've got a zillion other things to do, so no. I mean, just post a bug that shows the before and after of running pyupgrade on that file. Anyone with a basic grounding in Python should understand that |
I'm packaging your module as an rpm package so I'm using the typical PEP517 based build, install and test cycle used on building packages from non-root account.
python3 -sBm build -w --no-isolation
build
with--no-isolation
I'm using during all processes only locally installed modulesinstaller
modulecut off from access to the public network
(pytest is executed with-m "not network"
)Here is pytest output:
List of installed modules in build env:
Please let me know if you need more details or want me to perform some diagnostics.
The text was updated successfully, but these errors were encountered: