test: drop experimental benchmark

Signed-off-by: Alexander Bezzubov <[email protected]>

Author: bzz

driver/normalizer/strconv.go

@@ -60,9 +60,11 @@ func contains(s string, c byte) bool {
 	return strings.IndexByte(s, c) >= 0
 }
 
-// replaceEscapedMaybe returns a copy of s in which occurrences of old followed by a 
+// replaceEscapedMaybe returns a copy of s in which occurrences of old followed by a
 // non-digit are replaced by repl.
 // Is not part of the stdlib, handles the special case of JS escape sequence.
+// Regexp replacement and manual expansion performance was tested against the
+// current implementation and found this was fastest.
 func replaceEscapedMaybe(s, old, repl string) string {
 	var out strings.Builder
 	for s != "" {

driver/normalizer/strconv_test.go

@@ -1,9 +1,7 @@
 package normalizer
 
 import (
-	"regexp"
 	"testing"
-	"unicode/utf8"
 
 	"github.com/stretchr/testify/assert"
 	"github.com/stretchr/testify/require"
@@ -70,69 +68,6 @@ func printDebug(t *testing.T, quoted, actual string) {
 	}
 }
 
-func BenchmarkReplacingNullEscape_Iterative(b *testing.B) {
-	b.ReportAllocs()
-	for _, test := range testCasesUnquote {
-		for n := 0; n < b.N; n++ {
-			replaceEscapedMaybeIter(test.quoted, '0', '\x00')
-		}
-	}
-}
-
-// replaceEscapedMaybeIter is alternative implementation of replaceEscapedMaybe
-// It is only used in benchmark tests for performance comparison.
-func replaceEscapedMaybeIter(s string, old, new rune) string {
-	var runeTmp [utf8.UTFMax]byte
-	n := utf8.EncodeRune(runeTmp[:], new)
-
-	lastCp := 0
-	var buf []byte
-	for i, w := 0, 0; i < len(s); i += w {
-		r1, w1 := utf8.DecodeRuneInString(s[i:])
-		w = w1
-		if r1 == '\\' { // find sequence \\old[^0-9]
-			r2, w2 := utf8.DecodeRuneInString(s[i+w1:])
-			if r2 == old {
-				r3, _ := utf8.DecodeRuneInString(s[i+w1+w2:])
-				if 0 > r3 || r3 > 9 { // not a number after "\\old"
-					w += w2
-					if len(buf) == 0 {
-						buf = make([]byte, 0, 3*len(s)/2)
-					}
-					buf = append(buf, []byte(s[lastCp:i])...)
-					buf = append(buf, runeTmp[:n]...)
-					lastCp = i + w
-				}
-			}
-		}
-	}
-	if lastCp == 0 {
-		return s
-	}
-
-	if 0 < lastCp && lastCp < len(s) {
-		return string(append(buf, []byte(s[lastCp:len(s)])...))
-	}
-	return string(buf)
-}
-
-func BenchmarkReplacingNullEscape_Regexp(b *testing.B) {
-	b.ReportAllocs()
-	for _, test := range testCasesUnquote {
-		for n := 0; n < b.N; n++ {
-			replaceEscapedMaybeRegexp(test.quoted)
-		}
-	}
-}
-
-var re = regexp.MustCompile(`\\0([^0-9]|$)`)
-
-// replaceEscapedMaybeRegexp is alternative implementation of replaceEscapedMaybe
-// It is only used in benchmark tests for performance comparison.
-func replaceEscapedMaybeRegexp(s string) string {
-	return re.ReplaceAllString(s, "\x00$1")
-}
-
 func BenchmarkReplacingNullEscape_Simple(b *testing.B) {
 	b.ReportAllocs()
 	for _, test := range testCasesUnquote {