Secures invalid order parameters and adds test for it

Invalid means a number out of the set of accepted ones for iterator orders

Signed-off-by: ncordon <[email protected]>

Author: ncordon

src/main/scala/org/bblfsh/client/v2/BblfshClient.scala

@@ -209,17 +209,17 @@ object BblfshClient {
   implicit class BblfshClientMethods(val client: BblfshClient) {
     def filter(node: NodeExt, query: String) = BblfshClient.filter(node, query)
     def filter(node: JNode, query: String) = BblfshClient.filter(node, query)
-    def iterator(node: NodeExt, treeOrder: Int) = BblfshClient.iterator(node, treeOrder)
-    def iterator(node: JNode, treeOrder: Int) = BblfshClient.iterator(node, treeOrder)
+    def iterator(node: NodeExt, treeOrder: TreeOrder) = BblfshClient.iterator(node, treeOrder)
+    def iterator(node: JNode, treeOrder: TreeOrder) = BblfshClient.iterator(node, treeOrder)
   }
 
   /** Factory method for iterator over an external/native node */
-  def iterator(node: NodeExt, treeOrder: Int): Libuast.UastIterExt = {
+  def iterator(node: NodeExt, treeOrder: TreeOrder): Libuast.UastIterExt = {
     Libuast.UastIterExt(node, treeOrder)
   }
 
   /** Factory method for iterator over an managed node */
-  def iterator(node: JNode, treeOrder: Int): Libuast.UastIter = {
+  def iterator(node: JNode, treeOrder: TreeOrder): Libuast.UastIter = {
     Libuast.UastIter(node, treeOrder)
   }
 

src/main/scala/org/bblfsh/client/v2/package.scala

@@ -30,7 +30,7 @@ package object v2 {
   }
 
   /** Allow to use methods
-    * f(order: UastOrder) as f(0), f(1), f(2), ...
+    * f(order: TreeOrder) as f(0), f(1), f(2), ...
     * g(order: Int) as g(AnyOrder), g(PreOrder), g(PostOrder)
     */
   implicit def orderToInt(order: TreeOrder): Int = {

src/test/scala/org/bblfsh/client/v2/libuast/IteratorManagedTest.scala

@@ -180,4 +180,15 @@ class IteratorManagedTest extends FlatSpec
 
     posIter.close()
   }
+
+  "Managed UAST iterator with invalid numeric order" should "use AnyOrder" in {
+    val invalidNumIter = BblfshClient.iterator(testTree, -1)
+    val anyOrderIter = BblfshClient.iterator(testTree, AnyOrder)
+    val nodesNumIter = getNodeTypes(invalidNumIter)
+    val nodesAnyIter = getNodeTypes(anyOrderIter)
+    nodesNumIter shouldEqual nodesAnyIter
+
+    invalidNumIter.close()
+    anyOrderIter.close()
+  }
 }