Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CreateReadStream and CreateWriteStream #34

Open
fridjon opened this issue Jan 7, 2019 · 2 comments
Open

CreateReadStream and CreateWriteStream #34

fridjon opened this issue Jan 7, 2019 · 2 comments

Comments

@fridjon
Copy link

fridjon commented Jan 7, 2019

Are there any plans for implementing createReadStream and createWriteStream (they would be helpful when dealing with large files)? If welcomed I could work on a pull request for this.

I noticed that there is an old closed issue #9 opened in 2015 which resulted in a fork of this project to Node-SMB / marsaud-smb2. Are these projects likely to merge?

@bchelli
Copy link
Owner

bchelli commented Jan 8, 2019

Hi @fridjon,

There is no plan to develop these 2 features in a near future on my side.

That being said these functions are indeed very useful, if you want to own the development of these functions, PR are welcomed and likely to be merged.

Regarding the case the PR #9 the project was forked and was not mergable since the fork was too far away from the original source code. You could still use some of the base work done from marsaud and open a new pull request.

Thanks in advance for the contribution

@warpdesign
Copy link

createReadStream and createWriteStream are mentioned in the docs: are they supported? Maybe this issue could be closed then?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants