Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Redshift json implementation to use SUPER data type #76

Open
bcodell opened this issue Dec 17, 2024 · 2 comments
Open

Update Redshift json implementation to use SUPER data type #76

bcodell opened this issue Dec 17, 2024 · 2 comments

Comments

@bcodell
Copy link
Owner

bcodell commented Dec 17, 2024

Per comment below from @matthieu-carmeille the project would benefit redshift users to leverage the SUPER data type in redshift. Likely implementation needs:

  • Cast feature json column as super in build_json macro
  • Ensure attribute extraction when building dataset uses super-compatible extraction syntax

Original message:
Thank you so much @bcodell for the quick response. Next we should look into the column type: it is currently character varying, it would be way more performant with SUPER type in Redshift.

Originally posted by @matthieu-carmeille in #75 (comment)

@bcodell
Copy link
Owner Author

bcodell commented Dec 17, 2024

@matthieu-carmeille spun up a new issue. Does this scope seem about right? And is this something you could take on? I can tackle myself if you're too busy, though in that case I could use your help with testing as I don't have access to a redshift cluster of my own. Let me know - thanks!

@matthieu-carmeille
Copy link
Contributor

Hi @bcodell , please find here the related PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants