Skip to content

Commit 8483679

Browse files
committed
use fast global size estimate by default
1 parent 4b4b7f0 commit 8483679

File tree

1 file changed

+5
-3
lines changed

1 file changed

+5
-3
lines changed

src/cls/bdb/sql/StorageUtils.cls

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -768,11 +768,13 @@ ClassMethod AddRelated(def As %Dictionary.ClassDefinition, ByRef classes, includ
768768
}
769769

770770
/// Simple method to retrieve the storage consumption of your IRIS SQL table
771-
ClassMethod TableSize(tableName As %String = "", Output info, fast As %Boolean = 0, verbose As %Boolean = 1) As %Status
771+
ClassMethod TableSize(tableName As %String = "", Output info, fast As %Integer = 2, verbose As %Boolean = 1) As %Status
772772
{
773773
kill info
774774
set sc = $$$OK
775775
try {
776+
// revert to simple fast flag prior to 2023.3
777+
set:(fast=2)&&(($SYSTEM.Version.GetMajor()<2023)||($SYSTEM.Version.GetMinor()<3)) fast=1
776778

777779
if ('$system.SQL.Schema.TableExists(tableName, .metadata)) || ($ld(metadata,3)="") {
778780
set sc = $$$ERROR($$$TableDoesNotExist, tableName)
@@ -872,11 +874,11 @@ Warn(message, level="WARNING")
872874
}
873875

874876
/// SQL Query wrapper for <method>TableSize</method>
875-
Query TableSizeSQL(tableName As %String, fastSize As %Boolean = 0, showWarnings As %Boolean = 0) As %Query(ROWSPEC = "global:%String,allocatedMB:%Numeric,usedMB:%Numeric") [ SqlName = TableSize, SqlProc ]
877+
Query TableSizeSQL(tableName As %String, fastSize As %Integer = 0, showWarnings As %Boolean = 0) As %Query(ROWSPEC = "global:%String,allocatedMB:%Numeric,usedMB:%Numeric") [ SqlName = TableSize, SqlProc ]
876878
{
877879
}
878880

879-
ClassMethod TableSizeSQLExecute(ByRef qHandle As %Binary, tableName As %String, fastSize As %Boolean = 0, showWarnings As %Boolean = 0) As %Status [ Internal, ServerOnly = 1 ]
881+
ClassMethod TableSizeSQLExecute(ByRef qHandle As %Binary, tableName As %String, fastSize As %Integer = 0, showWarnings As %Boolean = 0) As %Status [ Internal, ServerOnly = 1 ]
880882
{
881883
kill qHandle
882884
set sc = ..TableSize(tableName, .info, fastSize, 0)

0 commit comments

Comments
 (0)