Remove case_sensitive from PathQuery.__init__

The case_sensitive parameter was only used in tests, which now use
monkeypatch to control the behavior of util.case_sensitive() instead.
This simplifies the PathQuery initialization logic while maintaining
test coverage.

Author: snejus

beets/dbcore/query.py

@@ -284,7 +284,7 @@ class PathQuery(FieldQuery[bytes]):
     # For tests
     force_implicit_query_detection = False
 
-    def __init__(self, field, pattern, fast=True, case_sensitive=None):
+    def __init__(self, field, pattern, fast=True):
         """Create a path query.
 
         `pattern` must be a path, either to a file or a directory.
@@ -296,14 +296,11 @@ def __init__(self, field, pattern, fast=True, case_sensitive=None):
 
         path = util.normpath(pattern)
 
-        # By default, the case sensitivity depends on the filesystem
-        # that the query path is located on.
-        if case_sensitive is None:
-            case_sensitive = util.case_sensitive(path)
-        self.case_sensitive = case_sensitive
+        # Case sensitivity depends on the filesystem that the query path is located on.
+        self.case_sensitive = util.case_sensitive(path)
 
         # Use a normalized-case pattern for case-insensitive matches.
-        if not case_sensitive:
+        if not self.case_sensitive:
             # We need to lowercase the entire path, not just the pattern.
             # In particular, on Windows, the drive letter is otherwise not
             # lowercased.

test/test_query.py

@@ -903,7 +903,9 @@ def lib(self, helper):
             _p("path:/c/\\\\x", ["with backslash"], id="backslash-escaped"),
         ],
     )
-    def test_explicit(self, lib, q, expected_titles):
+    def test_explicit(self, monkeypatch, lib, q, expected_titles):
+        monkeypatch.setattr("beets.util.case_sensitive", lambda *_: True)
+
         assert {i.title for i in lib.items(q)} == set(expected_titles)
 
     @pytest.mark.skipif(sys.platform == "win32", reason=WIN32_NO_IMPLICIT_PATHS)