Skip to content

Commit 0669fd0

Browse files
committed
Fixes
1 parent 6ff308f commit 0669fd0

File tree

2 files changed

+2
-4
lines changed

2 files changed

+2
-4
lines changed

README.md

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -370,10 +370,6 @@ We will use `cloudlabs-gcp.no` for this workshop. It is already configured in a
370370
371371
Verify that the DNS record is created in the GCP console. And go to the newly created address `http://<your-id>.cloudlabs-gcp.no`. The propagation of the address can take some time. Try using `dig @8.8.8.8 <your-id>.cloudlabs-gcp.no` to see if the address is ready. Look for `;; ANSWER SECTION:`, and find a line that looks like `<your-id>.cloudlabs-gcp.no. 60 IN A 34.160.83.207`. If you can't find the answer section, the DNS record might not be propagate yet (should not take more than a couple of minutes), or an error happened.
372372
373-
3. For google cloud run, there are [multiple options](https://cloud.google.com/run/docs/mapping-custom-domains) to set up DNS. The recommended way is to set up a global external Application Load Balancer, similar to what we did for the frontend CDN., we'll use the [`google_cloud_run_domain_mapping`]
374-
375-
<!-- TODO: Backend DNS, Backend HTTPS? -->
376-
377373
## Extras
378374
379375
### Frontend HTTPS

solutions/terraform.tf

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -29,6 +29,8 @@ output "current_user_email" {
2929
value = data.google_client_openid_userinfo.current.email
3030
}
3131

32+
data "google_project" "current" {}
33+
3234
# This check will display a warning to the participants if they forget to set
3335
# the id local variable in main.tf
3436
check "id_is_set" {

0 commit comments

Comments
 (0)