Add precautionary cast to long in length calculation

benjaminion · benjaminion · commit 7e11912b93d9 · 2020-08-13T09:33:08.000+01:00
diff --git a/rlp/src/main/java/org/web3j/rlp/RlpDecoder.java b/rlp/src/main/java/org/web3j/rlp/RlpDecoder.java
@@ -188,7 +188,7 @@ private static int calcLength(int lengthOfLength, byte[] data, int pos) {
         byte pow = (byte) (lengthOfLength - 1);
         long length = 0;
         for (int i = 1; i <= lengthOfLength; ++i) {
-            length += (data[pos + i] & 0xff) << (8 * pow);
+            length += ((long) (data[pos + i] & 0xff)) << (8 * pow);
             pow--;
         }
         if (length < 0 || length > Integer.MAX_VALUE) {

Original file line number	Diff line number	Diff line change
`@@ -188,7 +188,7 @@ private static int calcLength(int lengthOfLength, byte[] data, int pos) {`
`188`	`188`	`byte pow = (byte) (lengthOfLength - 1);`
`189`	`189`	`long length = 0;`
`190`	`190`	`for (int i = 1; i <= lengthOfLength; ++i) {`
`191`		`- length += (data[pos + i] & 0xff) << (8 * pow);`
	`191`	`+ length += ((long) (data[pos + i] & 0xff)) << (8 * pow);`
`192`	`192`	`pow--;`
`193`	`193`	`}`
`194`	`194`	`if (length < 0 \|\| length > Integer.MAX_VALUE) {`