Lunchtime stab at adding temporary halts on payments#6
Draft
the-frey wants to merge 1 commit into
Draft
Conversation
|
I like this approach. Only question is whether or not the halting should be a bit more granular. You could halt individual payments, rather than all payments to a recipient. And if you wanted to halt all payments to a specific recipient, you can pass in multiple payment ids to do so, which gives you feature parity with this draft. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Had a spare half hour. Initially went the route of removing payments but that approach would result in dodgy behaviour (I think!) when the following scenario occurs:
Therefore the non-destructive approach with filtering seemed to make more sense.
Hence putting it in a separate piece of state.
TODO:
Relates to #5