Skip to content

Commit 274516a

Browse files
committed
further slim down build matrix, reasoning in config comment
1 parent 80329a4 commit 274516a

File tree

1 file changed

+10
-7
lines changed

1 file changed

+10
-7
lines changed

.github/workflows/main.yml

+10-7
Original file line numberDiff line numberDiff line change
@@ -12,13 +12,13 @@ jobs:
1212

1313
strategy:
1414
matrix:
15-
# Run a full matrix only for the last 3 versions (where possible)
16-
elixir_version: ['1.16.3', '1.17.3', '1.18.1']
17-
otp_version: ['25.3', '26.2', '27.2']
18-
# Spot check older versions
15+
# Run tests at least once for every supported elixir or erlang version
16+
#
17+
# Since all the code is running at least once with each version, that should cover enough.
18+
# Like, what are the chances a bug would happen on 1.18@26 but not on 1.17@26 or 1.18@27?
19+
# And if it does, it's more likely an elixir bug than a benchee bug. We'll see.
20+
# We've been using enough of githubs CI resources and our own wait time :)
1921
#
20-
# Goal is to have old versions (elixir and erlang) have basically one test each.
21-
# That should be enough to affirm that they are working ok.
2222
# https://hexdocs.pm/elixir/compatibility-and-deprecations.html#between-elixir-and-erlang-otp
2323
include:
2424
- elixir_version: '1.7.4'
@@ -39,8 +39,11 @@ jobs:
3939
otp_version: '23.3'
4040
- elixir_version: '1.15.7'
4141
otp_version: '24.3'
42-
exclude:
4342
- elixir_version: '1.16.3'
43+
otp_version: '25.3'
44+
- elixir_version: '1.17.3'
45+
otp_version: '26.2'
46+
- elixir_version: '1.18.1'
4447
otp_version: '27.2'
4548

4649
steps:

0 commit comments

Comments
 (0)