Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for context managing and scandir.close() #69

Closed
h5rdly opened this issue Jan 3, 2017 · 1 comment
Closed

Support for context managing and scandir.close() #69

h5rdly opened this issue Jan 3, 2017 · 1 comment

Comments

@h5rdly
Copy link

h5rdly commented Jan 3, 2017

Hi,

First, thank you for this library, super useful.

I saw that Python 3.6 introduced context managing and the close() function to save resources. Would it be possible to add them to the autonomous scandir module as well? I use scandir rigorousy so that would be sweet :)

@benhoyt
Copy link
Owner

benhoyt commented Jan 3, 2017

Hi @h5rdly -- good call! This is a duplicate of #60 so I'm closing this one. Feel free to comment over there. I haven't been working on scandir for a while, so if you've done C+Python development you'd be most welcome to submit a patch to make this happen faster. Be aware it won't be trivial though: it will involve C code, Python code (for the pure Python fallback), unit tests, and documentation.

@benhoyt benhoyt closed this as completed Jan 3, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants