Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

error thrown with missing firstTap #173

Open
kewashi opened this issue Oct 8, 2023 · 1 comment
Open

error thrown with missing firstTap #173

kewashi opened this issue Oct 8, 2023 · 1 comment

Comments

@kewashi
Copy link

kewashi commented Oct 8, 2023

On line 364 the variable "firstTap" is not defined when you use swipe and doubleTap on the same page. It doesn't happen all the time but appears to happen when the item swiped on was never doubleTapped on. The fix is easy - add "firstTap &&" to the if statement. I didn't bother with a pull request but I can if you prefer. Here is the patched line:

            if (delta < settings.doubletap_int && (firstTap && $(e.target).index() == firstTap.index) && delta > 100) {
@benmajor
Copy link
Owner

benmajor commented Oct 9, 2023

Thanks @kewashi . If you could put together a PR for this, that would be great. I can then get it merged.

Cheers!
Ben.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants