Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

onBeforeTrackChange Provider property #513

Open
wants to merge 3 commits into
base: next
Choose a base branch
from
Open

Conversation

tyv
Copy link

@tyv tyv commented Jan 16, 2023

hey, this is regarding and closes #512
(took me a while to make it run)

I propose property onBeforeTrackChange to provider, which gets same args as goToTrack and should return same or new data with the same structure.

@benwiley4000
Copy link
Owner

Thanks for proposing some code. For now I'm not sure if I would be ready to merge it because the use case seems very niche. All other event handlers are after changes to playback state or for error handling. It's difficult to imagine what the broad use case would be for intercepting a request to go to the next track, since you already have control over the playlist contents and order. Could you explain why you need to skip some tracks, but you still allow the user to access them?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Correct way to set pause after a track is finished but before jumping to the next
2 participants