Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

React 17 update? #37

Open
PaperMold opened this issue Jan 17, 2022 · 4 comments · May be fixed by #39
Open

React 17 update? #37

PaperMold opened this issue Jan 17, 2022 · 4 comments · May be fixed by #39

Comments

@PaperMold
Copy link

Hey there!

Are you going to update this package to work with react 17?

Thanks in advance!
@derekantrican
Copy link

Or even react 18 at this point

@benwiley4000
Copy link
Owner

benwiley4000 commented Dec 7, 2023 •
edited
Loading

I think it works with any react version, is npm refusing to install because of the peer dependency?

@taktran taktran linked a pull request Jan 24, 2024 that will close this issue
Open
@taktran
Copy link

taktran commented Jan 24, 2024

I've created a PR to update for React 18: #39. Didn't support 17 tho, but feel free to comment on it.

@benwiley4000 The v0.4.2 built files did work with React 18, but the whole build/dev pipeline didn't, which makes it difficult to install in another project, so I made quite a few upgrades to the dependencies too.

@benwiley4000
Copy link
Owner

benwiley4000 commented Jan 24, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update dependencies to work with React 18 taktran/react-gif-player
4 participants
@taktran @derekantrican @benwiley4000 @PaperMold