Skip to content

fix(viewer): mount/unmount zoom viewer instead of Activity hide/show (2nd-open crash) #509

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Zheaoli merged 1 commit into from
May 31, 2026
Merged

fix(viewer): mount/unmount zoom viewer instead of Activity hide/show (2nd-open crash) #509

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 13 additions & 4 deletions components/album/progressive-image.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -191,8 +191,17 @@ export default function ProgressiveImage(
}}
/>
</Activity>
<Activity mode={showFullScreenViewer ? 'visible' : 'hidden'}>
{webGLAvailable ? <div
{/* Conditionally MOUNT the full-screen viewer rather than toggling an
<Activity> hidden/visible. <Activity> preserves the <canvas> DOM and
component state but runs the child's effect cleanup on hide — which
fires the WebGL engine's destroy()/loseContext(). Because the same
canvas is reused and `isInitialized` state is preserved, re-opening
never rebuilds the engine and lands on a permanently-lost context →
blank image + crash on the 2nd open. Mount/unmount gives every open a
fresh canvas + context (and destroy() on a discarded canvas stays
correct), fixing the crash while keeping the FU-13 leak fix intact. */}
{showFullScreenViewer && (
webGLAvailable ? <div
className="fixed inset-0 z-[100] bg-background/95 flex items-center justify-center"
onClick={(e) => {
// 点击背景关闭
Expand Down Expand Up @@ -283,8 +292,8 @@ export default function ProgressiveImage(
src={highResImageUrl}
alt={props.alt || 'image'}
/>
</div>}
</Activity>
</div>
)}
</>
) : null}

Expand Down
Loading