Plugin infrastructure relies on type_name, despite non-uniqueness guarantees

[GhostMinerPlus]

What problem does this solve or what need does it fill?

Here now, it seems that we use type names to check if a plugin has been added:

But acturally, the type name is not a unique identifier in rust:

So I think it is possible for different plugins to have the same type name. Once it happeded, our method above may lead to errors

What solution would you like?

Maybe we can use the TypeId instead

What alternative(s) have you considered?

...

Additional context

...

[alice-i-cecile]

Using type_id will limit our ability to add dynamically typed plugins in the future, and prevents mocking of plugins when #69 is implemented.

[mockersf]

we could use Plugin::name instead. it has no uniqueness guarantee, but plugins author would have more control and when it's not unique

[GhostMinerPlus]

Using type_id will limit our ability to add dynamically typed plugins in the future, and prevents mocking of plugins when #69 is implemented.

Thanks, I see

[GhostMinerPlus]

we could use Plugin::name instead. it has no uniqueness guarantee, but plugins author would have more control and when it's not unique

Yes, I think Plugin::name will work better. And we have used it at:

So it seems what we should do is making App::is_plugin_added use Plugin::name instead?

[alice-i-cecile]

Yep :) Should be a pretty easy PR if you want to try!