Skip to content

Skip picking for UI nodes if there is no pointer #22074

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mockersf merged 1 commit into from
Dec 9, 2025
Merged

Skip picking for UI nodes if there is no pointer #22074

mockersf merged 1 commit into from
Dec 9, 2025

Conversation

@ickshonpe
Copy link
Contributor

@ickshonpe ickshonpe commented Dec 9, 2025

Objective

ui_picking always iterates through all the uinodes even if no hits are possible because there's no pointer above the current camera.

Solution

Early continue if no pointers are found on the current camera.

@ickshonpe ickshonpe added D-Trivial Nice and easy! A great choice to get started with Bevy A-UI Graphical user interfaces, styles, layouts, and widgets A-Pointers Relating to Bevy pointer abstractions S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Dec 9, 2025
@mockersf mockersf added this pull request to the merge queue Dec 9, 2025
Merged via the queue into bevyengine:main with commit ad48f39 Dec 9, 2025
45 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mockersf mockersf mockersf approved these changes

Assignees

No one assigned

Labels

A-Pointers Relating to Bevy pointer abstractions A-UI Graphical user interfaces, styles, layouts, and widgets D-Trivial Nice and easy! A great choice to get started with Bevy S-Needs-Review Needs reviewer attention (from anyone!) to move forward

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ickshonpe @mockersf