Skip to content

Colors stack in the palette #563

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
knutsbyviktor opened this issue Jul 2, 2020 · 1 comment
Open

Colors stack in the palette #563

knutsbyviktor opened this issue Jul 2, 2020 · 1 comment

Comments

@knutsbyviktor
Copy link

knutsbyviktor commented Jul 2, 2020

Version 1.8.0
Downloaded locally and provided via Wro4J

The palette stacks the colors on top of eachother. After inspecting the palette I could see that the spans for the palette was nested into one another. See attached images

Faulty rendering

Faulty html

I unmified the source code and found that a </span> is missing from function paletteTemplate(p, color, className, opts) (row 119).
After modifying that row like this:
html.push('<span title="' + formattedString + '" data-color="' + tiny.toRgbString() + '" class="' + c + '"><span class="sp-thumb-inner" style="' + swatchStyle + ';" /></span></span>');

The desired output was obtained.

Correct rendering

``

@johnd0e
Copy link

johnd0e commented Jul 27, 2020

Duplicate of #558, already fixed in master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants