[Refactor] JSHint: Missing semicolons, spaces, unused variables, eqeqeq, indentation, etc.

Author: d-simon

lib/index.js

@@ -9,7 +9,6 @@ var cluster = require('cluster')
 // Starts either a server or client depending on whether this is a master or
 // worker cluster process
 exports = module.exports = function(options) {
-    var _this = this;
     var port = options.port || process.env.PORT || 3000;
 
     var server = require('./server');
@@ -19,7 +18,7 @@ exports = module.exports = function(options) {
 
     if(cluster.isMaster) {
 
-        for (i = 0; i < (options.workers || os.cpus().length); i += 1) {
+        for (var i = 0; i < (options.workers || os.cpus().length); i += 1) {
             console.log('starting worker thread #' + i);
             cluster.fork();
         }
@@ -43,8 +42,8 @@ exports = module.exports = function(options) {
 };
 
 fs.readdirSync(__dirname + '/plugins').forEach(function(filename){
-  if (!/\.js$/.test(filename)) return;
-  var name = basename(filename, '.js');
-  function load(){ return require('./plugins/' + name); }
-  Object.defineProperty(exports, name, {value: load});
+    if (!/\.js$/.test(filename)) return;
+    var name = basename(filename, '.js');
+    function load(){ return require('./plugins/' + name); }
+    Object.defineProperty(exports, name, {value: load});
 });

lib/plugins/s3HtmlCache.js

@@ -4,7 +4,8 @@ var s3 = new (require('aws-sdk')).S3({params:{Bucket: process.env.S3_BUCKET_NAME
 module.exports = {
     init: function() {
         this.cache = cache_manager.caching({
-            store: s3_cache, ttl: 10/*seconds*/
+            store: s3_cache,
+            ttl: 10/*seconds*/
         });
     },
 
@@ -27,7 +28,7 @@ module.exports = {
         this.cache.set(context.request.url, context.response.documentHTML);
         next();
     }
-}
+};
 
 
 var s3_cache = {
@@ -56,4 +57,4 @@ var s3_cache = {
             request.send();
         }
     }
-}
+};

lib/server.js

@@ -50,28 +50,28 @@ server._pluginEvent = function(methodName, args, callback) {
         } else {
             next();
         }
-    }
+    };
 
     args.push(next);
     next();
 };
 
 server.createPhantom = function() {
     var _this = this;
-    console.log('starting phantom')
+    console.log('starting phantom');
 
     phantom.create( "--load-images=false", "--ignore-ssl-errors=true", "--ssl-protocol=tlsv1", {
         binary: require('phantomjs').path,
         onExit: function() {
             _this.phantom = null;
-            console.log('phantom crashed, restarting...')
+            console.log('phantom crashed, restarting...');
             process.nextTick(_.bind(_this.createPhantom, _this));
         }
     }, _.bind(this.onPhantomCreate, this));
 };
 
 server.onPhantomCreate = function(phantom) {
-    console.log('started phantom')
+    console.log('started phantom');
     this.phantom = phantom;
     this.phantom.id = Math.random().toString(36);
 };
@@ -161,7 +161,7 @@ server.onResourceRequestedCallback = function (req, res, requestData) {
 // Decrement the number of pending requests left to download after a resource
 // is downloaded
 server.onResourceReceived = function (req, res, response) {
-    req.prerender.lastResourceReceived = new Date;
+    req.prerender.lastResourceReceived = new Date();
 
     //sometimes on redirects, phantomjs doesnt fire the 'end' stage of the original request, so we need to check it here
     if(util.normalizeUrl(req.prerender.url) === util.normalizeUrl(response.url) && response.status >= 300 && response.status <= 399) {
@@ -246,7 +246,7 @@ server.evaluateJavascriptOnPage = function(req, res) {
     req.prerender.page.evaluate(this.javascriptToExecuteOnPage, function(obj) {
         // Update the evaluated HTML
         req.prerender.documentHTML = obj.html;
-        req.prerender.lastJavascriptExecution = new Date;
+        req.prerender.lastJavascriptExecution = new Date();
 
         if(!obj.shouldWaitForPrerenderReady || (obj.shouldWaitForPrerenderReady && obj.prerenderReady)) {
             clearInterval(req.prerender.timeoutChecker);
@@ -293,7 +293,6 @@ server.javascriptToExecuteOnPage = function() {
 
 // Called when we're done evaluating the javascript on the page
 server.onPageEvaluate = function(req, res) {
-    var _this = this;
 
     if(req.prerender.stage >= 2) return;
 

lib/util.js

@@ -29,6 +29,6 @@ util.getUrl = function (req) {
     }
 
     var newUrl = url.format(parts);
-    if(newUrl[0] == '/') newUrl = newUrl.substr(1);
+    if(newUrl[0] === '/') newUrl = newUrl.substr(1);
     return newUrl;
 };