message accessor cannot be configured with ad-hoc configuration, throw exception if this is attempt; docs + test improvements

Author: flexponsive

config/http-client-logger.php

@@ -53,7 +53,7 @@
     |
     | These settings determine what data should be replaced with a placeholder.
     |
-    | - replace contains an array of strings that will be replaced anywhere in the request/response
+    | - replace contains an associative array of strings, where the key will be replaced with the value everywhere in the request/response
     | - replace_values will be replaced in headers, query parameters and json data (but not json keys)
     | - replace_headers contains an array of header names whose values are replaced with placeholders
     | - replace_query contains an array of query parameter names whose values are replaced with placeholders

src/HttpLogger.php

@@ -37,6 +37,12 @@ public function log(
         $this->response = $response;
         $this->sec = $sec;
         $this->context = $context;
+
+        // ad-hoc config is not supported for message accessor settings: replace_json, replace_query, replace_headers, replace_values.
+        if (Arr::hasAny($config, ['replace_json', 'replace_query', 'replace_headers', 'replace_values'])) {
+            throw new \InvalidArgumentException('Ad-hoc config does not support replace_json, replace_query, replace_headers, replace_values.');
+        }
+
         $this->config = array_merge(config('http-client-logger'), $config);
 
         if (Arr::get($this->config, 'channel')) {

tests/PsrMessageToStringConverterTest.php

@@ -61,6 +61,12 @@ public function test_to_string_replaces_sensitive_data()
             'sensitive data not replaced in URI'
         );
 
+        $this->assertStringNotContainsString(
+            '123456',
+            $string,
+            'sensitive data not replaced in json'
+        );
+
         $this->assertStringContainsString(
             'Host: ********.example.com:9000',
             $string,