Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Implicit model dependencies #59

Open
feluelle opened this issue Jun 12, 2024 · 1 comment
Open

Feature: Implicit model dependencies #59

feluelle opened this issue Jun 12, 2024 · 1 comment

Comments

@feluelle
Copy link

It would be great if we could make dependencies implicit by matching function arguments names to model names instead of having to also define them explicitly via ref(...).

@binste
Copy link
Owner

binste commented Jun 27, 2024

Sounds good! It would not work for sources where one also needs to provide the source name but maybe we could fall back on matching by function arguments if there is no depends_on decorator and in that case, all function arguments must be named after models. If a depends_on decorator is present, it's used instead.

Not sure when I'd get to this as it's a nice-to-have but not an urgent fix. I'm open for a PR on this if anyone wants to pick it up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants