Skip to content

build: Qt deprecated-declarations warnings #33571

@fanquake

Description

@fanquake

Building master (b510893) against Qt 6.10.0:

/root/bitcoin/src/qt/transactionfilterproxy.cpp: In member function ‘void TransactionFilterProxy::setDateRange(const std::optional<QDateTime>&, const std::optional<QDateTime>&)’:
/root/bitcoin/src/qt/transactionfilterproxy.cpp:57:21: warning: ‘void QSortFilterProxyModel::invalidateFilter()’ is deprecated: Use begin/endFilterChange() instead [-Wdeprecated-declarations]
   57 |     invalidateFilter();
      |     ~~~~~~~~~~~~~~~~^~
In file included from /usr/include/qt6/QtCore/QSortFilterProxyModel:1,
                 from /root/bitcoin/src/qt/transactionfilterproxy.h:11,
                 from /root/bitcoin/src/qt/transactionfilterproxy.cpp:5:
/usr/include/qt6/QtCore/qsortfilterproxymodel.h:128:10: note: declared here
  128 |     void invalidateFilter();
      |          ^~~~~~~~~~~~~~~~
/root/bitcoin/src/qt/transactionfilterproxy.cpp: In member function ‘void TransactionFilterProxy::setSearchString(const QString&)’:
/root/bitcoin/src/qt/transactionfilterproxy.cpp:64:21: warning: ‘void QSortFilterProxyModel::invalidateFilter()’ is deprecated: Use begin/endFilterChange() instead [-Wdeprecated-declarations]
   64 |     invalidateFilter();
      |     ~~~~~~~~~~~~~~~~^~
/usr/include/qt6/QtCore/qsortfilterproxymodel.h:128:10: note: declared here
  128 |     void invalidateFilter();
      |          ^~~~~~~~~~~~~~~~
/root/bitcoin/src/qt/transactionfilterproxy.cpp: In member function ‘void TransactionFilterProxy::setTypeFilter(quint32)’:
/root/bitcoin/src/qt/transactionfilterproxy.cpp:70:21: warning: ‘void QSortFilterProxyModel::invalidateFilter()’ is deprecated: Use begin/endFilterChange() instead [-Wdeprecated-declarations]
   70 |     invalidateFilter();
      |     ~~~~~~~~~~~~~~~~^~
/usr/include/qt6/QtCore/qsortfilterproxymodel.h:128:10: note: declared here
  128 |     void invalidateFilter();
      |          ^~~~~~~~~~~~~~~~
/root/bitcoin/src/qt/transactionfilterproxy.cpp: In member function ‘void TransactionFilterProxy::setMinAmount(const CAmount&)’:
/root/bitcoin/src/qt/transactionfilterproxy.cpp:76:21: warning: ‘void QSortFilterProxyModel::invalidateFilter()’ is deprecated: Use begin/endFilterChange() instead [-Wdeprecated-declarations]
   76 |     invalidateFilter();
      |     ~~~~~~~~~~~~~~~~^~
/usr/include/qt6/QtCore/qsortfilterproxymodel.h:128:10: note: declared here
  128 |     void invalidateFilter();
      |          ^~~~~~~~~~~~~~~~
/root/bitcoin/src/qt/transactionfilterproxy.cpp: In member function ‘void TransactionFilterProxy::setShowInactive(bool)’:
/root/bitcoin/src/qt/transactionfilterproxy.cpp:82:21: warning: ‘void QSortFilterProxyModel::invalidateFilter()’ is deprecated: Use begin/endFilterChange() instead [-Wdeprecated-declarations]
   82 |     invalidateFilter();
      |     ~~~~~~~~~~~~~~~~^~
/usr/include/qt6/QtCore/qsortfilterproxymodel.h:128:10: note: declared here
  128 |     void invalidateFilter();
      |          ^~~~~~~~~~~~~~~~

Need to clean these up as they'll start causing CI failures as soon as any CI is using 6.10.0 (probably native macos as soon as brew ships the 6.10.0 update).

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions