Merge #1706: musig/tests: initialize keypair

real-or-random · real-or-random · commit 020ee60495db · 2025-07-21T16:24:44.000+02:00
cde4130 musig/tests: initialize keypair (Jonas Nick) Pull request description: The keypair is unused in musig_partial_sign, but clang-snapshot gives a compiler warning anyway. ACKs for top commit: real-or-random: ACK cde4130 Tree-SHA512: 2a6c2b31c3ef8b5353c5dbdc156d052ff802d1f62d22214d952ee46223a9f87bc36b3ecdd49788381db379a01be83ded9def752747769b3751f3f058d57403e6
diff --git a/src/modules/musig/tests_impl.h b/src/modules/musig/tests_impl.h
@@ -918,6 +918,7 @@ static void musig_test_vectors_signverify(void) {
             continue;
         }
         CHECK(secp256k1_ec_pubkey_parse(CTX, &pubkey, vector->pubkeys[0], sizeof(vector->pubkeys[0])));
+        CHECK(secp256k1_keypair_create(CTX, &keypair, vector->sk));
 
         expected = c->error != MUSIG_AGGNONCE;
         CHECK(expected == secp256k1_musig_aggnonce_parse(CTX, &aggnonce, vector->aggnonces[c->aggnonce_index]));

Original file line number	Diff line number	Diff line change
`@@ -918,6 +918,7 @@ static void musig_test_vectors_signverify(void) {`
`918`	`918`	`continue;`
`919`	`919`	`}`
`920`	`920`	`CHECK(secp256k1_ec_pubkey_parse(CTX, &pubkey, vector->pubkeys[0], sizeof(vector->pubkeys[0])));`
	`921`	`+ CHECK(secp256k1_keypair_create(CTX, &keypair, vector->sk));`
`921`	`922`
`922`	`923`	`expected = c->error != MUSIG_AGGNONCE;`
`923`	`924`	`CHECK(expected == secp256k1_musig_aggnonce_parse(CTX, &aggnonce, vector->aggnonces[c->aggnonce_index]));`