Skip to content

Add apply_unconfirmed_txs to Wallet #636

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
andreasgriffin opened this issue Dec 10, 2024 · 2 comments · Fixed by #704
Closed

Add apply_unconfirmed_txs to Wallet #636

andreasgriffin opened this issue Dec 10, 2024 · 2 comments · Fixed by #704
Labels
enhancement New feature or request

Comments

@andreasgriffin
Copy link
Contributor

Describe the enhancement

Add apply_unconfirmed_txs to the bdk-ffi Wallet

Use case

  • It is useful to include local transactions to the wallet, to build new transactions ontop without actually broadcasting them yet.
  • It is also good to add transactions you know are in (most) mempools, but the client (e.g. kyoto) doesn't know about them
@andreasgriffin andreasgriffin added the enhancement New feature or request label Dec 10, 2024
@thunderbiscuit
Copy link
Member

This relates to a broader discussion, so I'll link some of those here:

  1. Don't double spend created transaction just because they haven't been broadcasted bdk_wallet#40
  2. Applied unconfirmed transactions need to be pruned after some time bdk#1666
  3. Let TxBuilder avoid previously used UTXOs (UTXO locking) bdk_wallet#166

@reez
Copy link
Collaborator

reez commented Mar 18, 2025

If possible if we can add to 1.2 since we will be releasing Kyoto in 1.2?

@reez reez linked a pull request Mar 20, 2025 that will close this issue
feat: apply_unconfirmed_txs on wallet #704
Merged
8 tasks
@reez reez mentioned this issue Mar 20, 2025
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: apply_unconfirmed_txs on wallet reez/bdk-ffi
3 participants
@reez @thunderbiscuit @andreasgriffin