test: add create custom fee rate for legacy descriptors

Author: realeinherjar

crates/bdk/tests/common.rs

@@ -108,10 +108,10 @@ pub fn get_funded_wallet(descriptor: &str) -> (Wallet, bitcoin::Txid) {
     get_funded_wallet_with_change(descriptor, None)
 }
 
-// This PKH can be obtained in testnet by using the 12-word seed
-// abandon x 11 + cactus and getting the first receiving address.
+// This PKH WIF was taken from example 5 in
+// https://github.com/libbitcoin/libbitcoin-explorer/wiki/bx-ec-to-wif
 pub fn get_test_pkh() -> &'static str {
-    "pkh(0275d93539d503d824ad0c69a4c23ae480700489de09378ba32c1776cf86d6bb93)"
+    "pkh(cNJFgo1driFnPcBdBX8BrJrpxchBWXwXCvNH5SoSkdcF6JXXwHMm)"
 }
 
 pub fn get_test_wpkh() -> &'static str {

crates/bdk/tests/wallet.rs

@@ -461,6 +461,16 @@ macro_rules! check_fee {
     }};
 }
 
+/// A floating point assert! that taker an additional third argument `delta`
+/// as a tolerance value when test for equality the first and second argument.
+macro_rules! assert_delta {
+    ($x:expr, $y:expr, $d:expr) => {
+        if !($x - $y < $d || $y - $x < $d) {
+            panic!();
+        }
+    };
+}
+
 #[test]
 fn test_create_tx_drain_wallet_and_drain_to() {
     let (mut wallet, _) = get_funded_wallet(get_test_wpkh());
@@ -542,10 +552,6 @@ fn test_create_tx_default_fee_rate() {
     assert_fee_rate!(psbt, fee.unwrap_or(0), FeeRate::default(), @add_signature);
 }
 
-// FIXME: Something is going on
-// thread 'test_legacy_create_tx_custom_fee_rate' panicked at 'assertion failed: `(left == right)`
-//  left: `FeeRate(9.537815)`,
-// right: `FeeRate(5.0)`'
 #[test]
 fn test_legacy_create_tx_custom_fee_rate() {
     let (mut wallet, _) = get_funded_wallet(get_test_pkh());
@@ -554,9 +560,16 @@ fn test_legacy_create_tx_custom_fee_rate() {
     builder
         .add_recipient(addr.script_pubkey(), 25_000)
         .fee_rate(FeeRate::from_sat_per_vb(5.0));
-    let psbt = builder.finish().unwrap();
+    let mut psbt = builder.finish().unwrap();
 
-    assert_eq!(psbt.fee_rate().unwrap(), FeeRate::from_sat_per_vb(5.0));
+    // sign the transaction
+    wallet.sign(&mut psbt, SignOptions::default()).unwrap();
+
+    assert_delta!(
+        psbt.fee_rate().unwrap(),
+        FeeRate::from_sat_per_vb(5.0),
+        FeeRate::from_sat_per_vb(0.6)
+    )
 }
 
 #[test]