Skip to content

Create an example Ledger custom signer #833

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
notmandatory opened this issue Jan 11, 2023 · 3 comments
Closed

Create an example Ledger custom signer #833

notmandatory opened this issue Jan 11, 2023 · 3 comments
Labels
new feature New feature or request

Comments

@notmandatory
Copy link
Member

Describe the enhancement

Create an example of a BDK wallet custom signer using the Ledger ledger_bitcoin_client crate. This might make sense to split into a new optional module. See the bitcoin_client_rs repo.

Use case

Since Ledger now provides a rust based client library and on-device descriptor and miniscript support it would be useful for BDK users to have an example custom signer that implements SignerCommon and InputSigner traits and could be added to a Wallet with the wallet.add_signer() function.

Additional context

This issue was inspired by a conversation with @Rob1Ham.

@notmandatory notmandatory added the new feature New feature or request label Jan 11, 2023
@Rob1Ham
Copy link

Rob1Ham commented Jan 16, 2023

Having BDK natively interact with the ledger rust library would be a huge win!

Tagging @bigspider on the ledger team as well as @edouardparis @darosior @kloaec from the revault team who have ledger currently working with their wallet Liana. They may have some opinions on the utility of this.

@darosior
Copy link
Contributor

darosior commented Jan 16, 2023 via email

@notmandatory
Copy link
Member Author

Closing in favor of bitcoindevkit/bdk_wallet#20.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new feature New feature or request
Projects
Status: No status
Development

No branches or pull requests

3 participants