Skip to content

Add legacy wallet tests #134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
Tracked by #78
realeinherjar opened this issue Sep 20, 2023 · 1 comment · May be fixed by #214
Open
Tracked by #78

Add legacy wallet tests #134

realeinherjar opened this issue Sep 20, 2023 · 1 comment · May be fixed by #214
Assignees
@realeinherjar
Labels
tests New or improved tests

Comments

@realeinherjar
Copy link
Contributor

realeinherjar commented Sep 20, 2023 •
edited
Loading

This discussion came up on bitcoindevkit/bdk#1115.

Currently we are only testing segwit wallets:
https://github.com/bitcoindevkit/bdk/blob/f95506ba6a4a92e977ad228114683164c4ca1222/crates/bdk/tests/common.rs#L107-L156

Do we want to support legacy wallets?
If yes, we need legacy wallet tests.
@realeinherjar realeinherjar mentioned this issue Sep 20, 2023
Closed
8 tasks
@nondiremanuel nondiremanuel mentioned this issue Sep 23, 2023
Closed
40 tasks
@nondiremanuel nondiremanuel moved this to Todo in BDK Wallet Sep 26, 2023
@nondiremanuel nondiremanuel added the tests New or improved tests label Sep 26, 2023
@ValuedMammal
Copy link
Collaborator

A couple ideas for this: we should change the assert_feerate macro to just a plain vanilla function - right now it's difficult to read and not very approachable. It should take in an optional descriptor string to calculate the satisfaction weight instead of assume the same P2WPKH_FAKE_WITNESS_SIZE for every psbt. We can add some legacy descriptors to wallet/tests/common.rs and then come up with a similar assert_feerate_legacy that contains logic specific to pre-segwit transactions.

@notmandatory notmandatory transferred this issue from bitcoindevkit/bdk Apr 7, 2025
@luisschwab luisschwab linked a pull request May 2, 2025 that will close this issue
Open
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@realeinherjar realeinherjar

Labels
tests New or improved tests
Projects
BDK Wallet
Status: In Progress
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

test: add legacy descriptor tests luisschwab/bdk_wallet
3 participants
@nondiremanuel @ValuedMammal @realeinherjar