build: remove "default" feature gating

The "default" feature argument is redundant and
unclear, as it requires the developer to know
which aspects of the default features apply to a
particular cfg attribute. This change simplifies
feature gating logic by only requiring the features
necessary to build with a given feature set.

Author: ValuedMammal

src/lib.rs

@@ -24,23 +24,12 @@ extern crate core;
 extern crate log;
 #[cfg(feature = "use-openssl")]
 extern crate openssl;
-#[cfg(all(
-    any(
-        feature = "default",
-        feature = "use-rustls",
-        feature = "use-rustls-ring"
-    ),
-    not(feature = "use-openssl")
-))]
+#[cfg(any(feature = "use-rustls", feature = "use-rustls-ring"))]
 extern crate rustls;
 extern crate serde;
 extern crate serde_json;
 
-#[cfg(any(
-    feature = "default",
-    feature = "use-rustls",
-    feature = "use-rustls-ring"
-))]
+#[cfg(any(feature = "use-rustls", feature = "use-rustls-ring"))]
 extern crate webpki_roots;
 
 #[cfg(feature = "proxy")]

src/raw_client.rs

@@ -22,21 +22,15 @@ use bitcoin::{Script, Txid};
 #[cfg(feature = "use-openssl")]
 use openssl::ssl::{SslConnector, SslMethod, SslStream, SslVerifyMode};
 
-#[cfg(all(
-    any(
-        feature = "default",
-        feature = "use-rustls",
-        feature = "use-rustls-ring"
-    ),
-    not(feature = "use-openssl")
-))]
+#[cfg(any(feature = "use-rustls", feature = "use-rustls-ring"))]
+#[allow(unused_imports)]
 use rustls::{
     pki_types::ServerName,
     pki_types::{Der, TrustAnchor},
     ClientConfig, ClientConnection, RootCertStore, StreamOwned,
 };
 
-#[cfg(any(feature = "default", feature = "proxy"))]
+#[cfg(feature = "proxy")]
 use crate::socks::{Socks5Stream, TargetAddr, ToTargetAddr};
 
 use crate::stream::ClonableStream;
@@ -93,7 +87,7 @@ impl ToSocketAddrsDomain for (&str, u16) {
     }
 }
 
-#[cfg(any(feature = "default", feature = "proxy"))]
+#[cfg(feature = "proxy")]
 impl ToSocketAddrsDomain for TargetAddr {
     fn domain(&self) -> Option<&str> {
         match self {
@@ -289,14 +283,8 @@ impl RawClient<ElectrumSslStream> {
     }
 }
 
-#[cfg(all(
-    any(
-        feature = "default",
-        feature = "use-rustls",
-        feature = "use-rustls-ring"
-    ),
-    not(feature = "use-openssl")
-))]
+#[cfg(any(feature = "use-rustls", feature = "use-rustls-ring"))]
+#[allow(unused)]
 mod danger {
     use crate::raw_client::ServerName;
     use rustls::client::danger::{HandshakeSignatureValid, ServerCertVerified};
@@ -350,21 +338,13 @@ mod danger {
 }
 
 #[cfg(all(
-    any(
-        feature = "default",
-        feature = "use-rustls",
-        feature = "use-rustls-ring"
-    ),
+    any(feature = "use-rustls", feature = "use-rustls-ring"),
     not(feature = "use-openssl")
 ))]
 /// Transport type used to establish a Rustls TLS encrypted/authenticated connection with the server
 pub type ElectrumSslStream = StreamOwned<ClientConnection, TcpStream>;
 #[cfg(all(
-    any(
-        feature = "default",
-        feature = "use-rustls",
-        feature = "use-rustls-ring"
-    ),
+    any(feature = "use-rustls", feature = "use-rustls-ring"),
     not(feature = "use-openssl")
 ))]
 impl RawClient<ElectrumSslStream> {