Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Timezone override #336

Open
CaseyInHaengsin opened this issue Feb 27, 2025 · 2 comments
Open

Timezone override #336

CaseyInHaengsin opened this issue Feb 27, 2025 · 2 comments

Comments

@CaseyInHaengsin
Copy link
Contributor

Hello,

I have a use case where I need to render pages with different time zones; I found that this is possible via Emulation.setTimezoneOverride. Are you open to a PR that would add support for this functionality?

@maltoe
Copy link
Collaborator

maltoe commented Feb 28, 2025

In the Navigate protocol as a set_timezone option perhaps? Sure.

Be aware there's a "hidden feature" that allows you to supply custom protocols as well, which would make this task rather easy to do without changes to ChromicPDF

but also open to add this as a new option

@CaseyInHaengsin
Copy link
Contributor Author

Thank you, @maltoe! I am open to using the hidden feature if that makes more sense. I did want to attempt implementing the set_timezone option. I'm definitely open to feedback/suggestions/teasing on PR #338.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants