From ec756a59d9bb446f373ce880896db00f760d3c0b Mon Sep 17 00:00:00 2001 From: koalix Date: Tue, 1 Oct 2019 20:38:59 +0200 Subject: [PATCH 1/3] ESLint cleanup and a fix of the issue #246. --- browser/queue.js | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/browser/queue.js b/browser/queue.js index 55059722..aef40e44 100644 --- a/browser/queue.js +++ b/browser/queue.js @@ -8,8 +8,7 @@ var FuncUnit = require("funcunit/browser/core"); */ FuncUnit._incallback = false; //where we should add things in a callback -var currentPosition = 0, - startedQueue = false; +var currentPosition = 0; /** * @property FuncUnit.speed F.speed() @@ -99,14 +98,14 @@ add = function(handler, error, context) { if(handler instanceof Function) { if(typeof error === 'object') { context = error; - delete error; + error = null; } error = (error && error.toString()) || 'Custom method has failed.'; var cb = handler; handler = { - method: function(success, error) { + method: function(success, error) { // eslint-disable-line no-unused-vars success(); }, success: cb, @@ -143,7 +142,7 @@ var currentEl; * @param {Object} selector */ FuncUnit._done = function(el, selector){ - var next, + var next, timer, speed = FuncUnit.speed || 0; From e1fb1c29b767333d51c063e3195364e762940b3a Mon Sep 17 00:00:00 2001 From: Manuel Mujica Date: Thu, 31 Oct 2019 15:47:13 -0300 Subject: [PATCH 2/3] Set xenial dist to use xvfb --- .travis.yml | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/.travis.yml b/.travis.yml index 01944c4c..82c97435 100644 --- a/.travis.yml +++ b/.travis.yml @@ -1,3 +1,6 @@ +dist: xenial +services: + - xvfb sudo: false language: node_js node_js: @@ -6,6 +9,4 @@ node_js: - node before_install: - ./bin/firefox-allow-popups.sh - - "export DISPLAY=:99.0" - - "sh -e /etc/init.d/xvfb start" script: npm run ci From 942325072f96bbb34e83a807b1c5e114f78d1615 Mon Sep 17 00:00:00 2001 From: Manuel Mujica Date: Thu, 31 Oct 2019 16:08:06 -0300 Subject: [PATCH 3/3] Remove Node 6 from Travis config --- .travis.yml | 1 - 1 file changed, 1 deletion(-) diff --git a/.travis.yml b/.travis.yml index 82c97435..7ef4697d 100644 --- a/.travis.yml +++ b/.travis.yml @@ -4,7 +4,6 @@ services: sudo: false language: node_js node_js: - - 6 - 8 - node before_install: