fix: Enable diagnostic remarks only with debug log (#180)

Author: zsolt-marta-bitrise

cmd/xcode/xcodebuild.go

@@ -333,8 +333,13 @@ func getArgsToPass(config xcelerate.Config, xcodeArgs xcodeargs.XcodeArgs) []str
 
 	if config.BuildCacheEnabled {
 		additional = maps.Clone(xcodeargs.CacheArgs)
+		diagnosticRemarks := "NO"
+		if config.DebugLogging {
+			diagnosticRemarks = "YES"
+		}
 		maps.Copy(additional, map[string]string{
-			"COMPILATION_CACHE_REMOTE_SERVICE_PATH": config.ProxySocketPath,
+			"COMPILATION_CACHE_REMOTE_SERVICE_PATH":       config.ProxySocketPath,
+			"COMPILATION_CACHE_ENABLE_DIAGNOSTIC_REMARKS": diagnosticRemarks,
 		})
 	}
 

internal/xcelerate/xcodeargs/args.go

@@ -18,7 +18,6 @@ type XcodeArgs interface {
 
 var CacheArgs = map[string]string{
 	"COMPILATION_CACHE_ENABLE_PLUGIN":               "YES",
-	"COMPILATION_CACHE_ENABLE_DIAGNOSTIC_REMARKS":   "YES",
 	"COMPILATION_CACHE_ENABLE_INTEGRATED_QUERIES":   "YES",
 	"COMPILATION_CACHE_ENABLE_DETACHED_KEY_QUERIES": "YES",
 	"SWIFT_ENABLE_COMPILE_CACHE":                    "YES",