Skip to content

Conversation

@quexten
Copy link
Contributor

@quexten quexten commented Sep 30, 2025

🎟️ Tracking

📔 Objective

This PR removes old unused feature flags related to ssh keys. These are no longer needed since the feature has been rolled out for over half a year.

📸 Screenshots

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@quexten quexten requested a review from a team as a code owner September 30, 2025 11:00
@quexten quexten marked this pull request as draft September 30, 2025 11:00
@quexten quexten removed the request for review from shane-melton September 30, 2025 11:00
@claude

This comment was marked as resolved.

@sonarqubecloud
Copy link

@codecov
Copy link

codecov bot commented Sep 30, 2025

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 50.08%. Comparing base (3a6b956) to head (3ffe666).
⚠️ Report is 9 commits behind head on main.

Files with missing lines Patch % Lines
src/Api/Vault/Controllers/SyncController.cs 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6400      +/-   ##
==========================================
- Coverage   54.40%   50.08%   -4.33%     
==========================================
  Files        1839     1839              
  Lines       81510    81529      +19     
  Branches     7209     7213       +4     
==========================================
- Hits        44346    40832    -3514     
- Misses      35515    39132    +3617     
+ Partials     1649     1565      -84     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions
Copy link
Contributor

Logo
Checkmarx One – Scan Summary & Detailsf2f0ae48-ed04-43f6-af2b-a493b5293d0d

Great job! No new security vulnerabilities introduced in this pull request

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants