-
Notifications
You must be signed in to change notification settings - Fork 1.5k
[PM-26361] Add User Auto Confirmation #6436
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
New Issues (3)Checkmarx found the following issues in this Pull Request
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking at the documentation this is missing some updates:
Add the new column to the following sprocs and views:
Organization_Create.sql
Organization_ReadAbilities.sql
Organization_Update.sql
OrganizationUserOrganizationDetailsView.sql
ProviderUserProviderOrganizationDetailsView.sql
Add the new property to the following models:
src/Api/AdminConsole/Models/Response/Organizations/OrganizationResponseModel.cs
src/Api/AdminConsole/Models/Response/ProfileOrganizationResponseModel.cs
src/Api/AdminConsole/Models/Response/ProfileProviderOrganizationResponseModel.cs
src/Core/AdminConsole/Models/Data/Organizations/OrganizationUsers/OrganizationUserOrganizationDetails.cs
src/Core/AdminConsole/Models/Data/Provider/ProviderUserOrganizationDetails.cs
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #6436 +/- ##
==========================================
+ Coverage 50.73% 54.89% +4.16%
==========================================
Files 1866 1866
Lines 82726 82750 +24
Branches 7318 7320 +2
==========================================
+ Hits 41973 45428 +3455
+ Misses 39150 35643 -3507
- Partials 1603 1679 +76 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…onse models. Updating sprocs and views. Updating migrations
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Billing changes look good!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly nit-picks and one concern about refreshing views.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM


🎟️ Tracking
PM-26361
📔 Objective
This adds AutomaticUserConfirmation to Organization, OrganizationAbility, OrganizationLicense, and Plan. This also adds it to the Admin portal as a checkable box for Organization features. This also adds the feature to the claims factory and claim constant.
📸 Screenshots
Admin Portal Checkbox

⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes