Skip to content

Conversation

@renovate
Copy link
Contributor

@renovate renovate bot commented Oct 13, 2025

This PR contains the following updates:

Package Change Age Confidence
Microsoft.NET.Test.Sdk 17.12.0 -> 18.0.1 age confidence
Microsoft.NET.Test.Sdk 17.8.0 -> 18.0.1 age confidence

Release Notes

microsoft/vstest (Microsoft.NET.Test.Sdk)

v18.0.1

What's Changed

Fixing an issue with loading covrun64.dll on systems that have .NET 10 SDK installed: https://learn.microsoft.com/en-us/dotnet/core/compatibility/sdk/10.0/code-coverage-dynamic-native-instrumentation

Internal changes

Full Changelog: microsoft/vstest@v18.0.0...v18.0.1

v18.0.0

What's Changed

Internal fixes and updates

New Contributors

Full Changelog: microsoft/vstest@v17.14.1...v18.0.0

v17.14.1

What's Changed

Full Changelog: microsoft/vstest@v17.14.0...v17.14.1

v17.14.0

What's Changed

.NET versions updated

This version of VS Test upgraded .NET to net8 and net9. All projects targeting net6.0 (or other end-of-life .NET target frameworks) should pin their version of Microsoft.NET.Test.SDK to 17.13.0, or update the projects to net8 or newer. We remain backwards compatible with previous versions of Microsoft.NET.Test.SDK. This change does NOT prevent you from:

  • Updating to the latest VS, and running tests from net6.0 test projects.
  • Updating to the latest .NET SDK, and running tests from net6.0 test projects.

It also has no impact on .NET Framework projects, where we continue targeting .NET Framework 4.6.2.

Changes
Internal version updates and fixes

New Contributors

Full Changelog: microsoft/vstest@v17.13.0...v17.14.0

v17.13.0

What's Changed

New Contributors

Full Changelog: microsoft/vstest@v17.12.0...v17.13.0


Configuration

📅 Schedule: Branch creation - "every 2nd week starting on the 2 week of the year before 4am on Monday" (UTC), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about these updates again.


  • If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

@codecov
Copy link

codecov bot commented Oct 13, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 53.64%. Comparing base (2e0a416) to head (e88ac64).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6449      +/-   ##
==========================================
- Coverage   53.64%   53.64%   -0.01%     
==========================================
  Files        1926     1926              
  Lines       85711    85711              
  Branches     7686     7686              
==========================================
- Hits        45978    45977       -1     
- Misses      37961    37962       +1     
  Partials     1772     1772              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@renovate renovate bot force-pushed the renovate/major-vstest-monorepo branch from 44d7873 to 39e8394 Compare October 21, 2025 13:47
@renovate renovate bot force-pushed the renovate/major-vstest-monorepo branch from 39e8394 to 1814a5f Compare November 10, 2025 15:35
@renovate renovate bot force-pushed the renovate/major-vstest-monorepo branch from 1814a5f to 607d13a Compare November 18, 2025 14:37
@renovate renovate bot force-pushed the renovate/major-vstest-monorepo branch from 607d13a to 2b8f938 Compare November 28, 2025 14:39
@djsmith85 djsmith85 self-requested a review December 9, 2025 13:14
@claude
Copy link
Contributor

claude bot commented Dec 9, 2025

Claude finished @renovate[bot]'s task —— View job


Code Review Complete ✓

Tasks

  • Analyze PR changes with bitwarden-code-reviewer
  • Review findings and provide feedback
  • Post comprehensive review

Review Summary

Overall Assessment:APPROVE - Safe to merge

This PR updates Microsoft.NET.Test.Sdk from version 17.x to 18.0.1. After thorough analysis, this dependency update is safe and ready to merge.

Key Findings

✅ Framework Compatibility

  • All 21 test projects in the repository target net8.0
  • v18.0.0 requires net8.0+ (dropped support for net6.0 and other EOL frameworks)
  • The Bitwarden server codebase is fully compatible with these breaking changes
  • No projects need to pin to the older v17.13.0 version

✅ Breaking Changes Assessment

  • v18.0.0 dropped net6.0 support per release notes
  • This doesn't affect this codebase since all test projects use net8.0
  • v18.0.1 is a bug fix release addressing code coverage issues with .NET 10 SDK
  • Backwards compatible with older .NET SDK versions
  • No impact on .NET Framework 4.6.2 projects

✅ Improved Consistency

  • Previously, two test projects had hardcoded versions:
    • test/Core.IntegrationTest/Core.IntegrationTest.csproj used 17.8.0
    • test/Infrastructure.Dapper.Test/Infrastructure.Dapper.Test.csproj used 17.12.0
  • Now all test projects reference the centralized $(MicrosoftNetTestSdkVersion) variable
  • This improves maintainability for future updates

✅ Security & Compliance

  • No security vulnerabilities introduced
  • Official Microsoft package from trusted source
  • No impact on Bitwarden's zero-knowledge encryption architecture
  • No sensitive data exposure risks
  • Standard testing infrastructure update

Files Changed

  1. Directory.Build.props - Updated centralized version variable from 17.8.0 to 18.0.1
  2. test/Core.IntegrationTest/Core.IntegrationTest.csproj - Migrated from hardcoded 17.8.0 to centralized variable
  3. test/Infrastructure.Dapper.Test/Infrastructure.Dapper.Test.csproj - Migrated from hardcoded 17.12.0 to centralized variable

Recommendation

This PR is ready to merge once CI passes. The update:

  • Maintains full framework compatibility
  • Improves version management consistency across test projects
  • Contains no security or breaking change risks
  • Follows best practices for automated dependency updates

@djsmith85
Copy link
Contributor

This PR supersedes #5738

@renovate
Copy link
Contributor Author

renovate bot commented Dec 9, 2025

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.

You can manually request rebase by checking the rebase/retry box above.

⚠️ Warning: custom changes will be lost.

@github-actions
Copy link
Contributor

github-actions bot commented Dec 9, 2025

Logo
Checkmarx One – Scan Summary & Details953bae3b-22e2-4237-bb6a-8f4356573a78

Great job! No new security vulnerabilities introduced in this pull request

@djsmith85 djsmith85 merged commit d26b5fa into main Dec 9, 2025
43 checks passed
@djsmith85 djsmith85 deleted the renovate/major-vstest-monorepo branch December 9, 2025 13:40
@djsmith85 djsmith85 changed the title [deps]: Update Microsoft.NET.Test.Sdk to v18 [PM-29485][deps]: Update Microsoft.NET.Test.Sdk to v18 Dec 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants