Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add logging #80

Open
SaadBazaz opened this issue Oct 15, 2023 · 3 comments
Open

Add logging #80

SaadBazaz opened this issue Oct 15, 2023 · 3 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@SaadBazaz
Copy link

Pino could do a good job.

@blomqma
Copy link
Owner

blomqma commented Oct 18, 2023

Yeah I think the existing logging could be improved for sure. What kind of information would you expect to see logged by the framework?

@SaadBazaz
Copy link
Author

SaadBazaz commented Oct 19, 2023

Something more on the lines of how NestJS manages em. For production, they throw JSON in the terminal. For dev, it's formatted.

https://docs.nestjs.com/techniques/logger

Mostly we see:
Status code
Route
Time hit
User Agent
Response

With the right colors.

@blomqma
Copy link
Owner

blomqma commented Oct 19, 2023

Something more on the lines of how NestJS manages em. For production, they throw JSON in the terminal. For dev, it's formatted.

https://docs.nestjs.com/techniques/logger

Mostly we see: Status code Route Time hit User Agent Response

With the right colors.

Seems reasonable. I could look into this at some point, keeping this issue open for now.

@blomqma blomqma added enhancement New feature or request help wanted Extra attention is needed labels Apr 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants