From 18e8178fb2b447c1e2ab228b19dae8f4bc3e9460 Mon Sep 17 00:00:00 2001 From: Christoph Rueger Date: Sat, 15 Mar 2025 12:31:01 +0100 Subject: [PATCH] hint that Eclipse restart is required adjust description of the warning, so at least it is mentioned somewhere. unfortunatelly I could not figure out how to reliably sync the Processor.pendatic field with the .bnd files on change. The problem is that Processor.pendatic can be set via .bnd files but also via Processor.setPedantic(boolean) e.g. from testcases, there is some magic caching going on in Processor.begin() and Processor.getProperties() which I was not able to figure out, what to call so that the Workspace Refresh Button behaves the same as an Eclipse restart. Signed-off-by: Christoph Rueger Update pedantic.md --- biz.aQute.bndlib/src/aQute/bnd/help/Syntax.java | 4 +++- docs/_instructions/pedantic.md | 7 +++---- 2 files changed, 6 insertions(+), 5 deletions(-) diff --git a/biz.aQute.bndlib/src/aQute/bnd/help/Syntax.java b/biz.aQute.bndlib/src/aQute/bnd/help/Syntax.java index 569f157200..190408f5a6 100644 --- a/biz.aQute.bndlib/src/aQute/bnd/help/Syntax.java +++ b/biz.aQute.bndlib/src/aQute/bnd/help/Syntax.java @@ -576,7 +576,9 @@ null, null, new Syntax("name", "The display name of the developer", "name='Peter "If set, is used a template to calculate the output file. It can use any macro but the ${@bsn} and ${@version} macros refer to the current JAR being saved. The default is bsn + \".jar\".", OUTPUTMASK + "=my_file.zip", null, null), new Syntax(PACKAGEINFOTYPE, "Sets the different types of package info.", PACKAGEINFOTYPE + "=osgi", null, null), - new Syntax(PEDANTIC, "Warn about things that are not really wrong but still not right.", PEDANTIC + "=true", + new Syntax(PEDANTIC, + "Warn about things that are not really wrong but still not right. Note: Currently a change to this instruction requires a restart of Eclipse.", + PEDANTIC + "=true", "true,false", Verifier.TRUEORFALSEPATTERN), new Syntax(PLUGIN, "Define the plugins.", diff --git a/docs/_instructions/pedantic.md b/docs/_instructions/pedantic.md index 4ef7e8db36..76febfdae2 100644 --- a/docs/_instructions/pedantic.md +++ b/docs/_instructions/pedantic.md @@ -5,8 +5,7 @@ title: -pedantic BOOLEAN summary: Warn about things that are not really wrong but still not right. --- - protected void begin() { - if (isTrue(getProperty(PEDANTIC))) - setPedantic(true); - } +When setting this instruction to `true` there will be more warnings about *things that are not really wrong but still not right*. +It can be helpful to fix problems in your workspace. +**Note for Eclipse users:** Currently a change to this instruction requires a restart of Eclipse. The Refresh-Workspace button is not enough. \ No newline at end of file