WiFiSecureClient crashes during connection

[karesztrk]

The WiFiSecureClient is crashes during the connection establishment if used together with this library. Im using it on a NodeMCU esp8266.

Its related to this part:

#if ARDUINO_VERSION <= 106
    // "yield" is not implemented as noop in older Arduino Core releases, so let's define it.
    // See also: https://stackoverflow.com/questions/34497758/what-is-the-secret-of-the-arduino-yieldfunction/34498165#34498165
    void yield(void) {};
#endif

If i remove the function definition it works correctly.
Please consider to refactor your solution.
Thanks in advance.

[amotl]

Hi Károly,

we added this part with #59 the other day. I believe nobody runs this ancient Arduino Core releases anymore, so this might well be removed. However, @el3ctrician also made an improvement here by #113 to let it stay in the code, it reads like:

#ifndef ESP8266
    #if ARDUINO_VERSION <= 106
        // "yield" is not implemented as noop in older Arduino Core releases, so let's define it.
        // See also: https://stackoverflow.com/questions/34497758/what-is-the-secret-of-the-arduino-yieldfunction/34498165#34498165
        void yield(void) {};
    #endif
#endif

Hope this helps.

Cheers,
Andreas.

[bogde]

Changes were merged into the main branch.

[amotl]

Dear Bogdan,

thanks a bunch and also for addressing #113 while being at it.

Thanks,
Andreas.

[amotl]

Just wanted to let you know we got rid of the yield() polyfill altogether [1], so this should never be an issue anymore.

I believe we can well close this issue.

[1] https://github.com/hiveeyes/HX711/tree/spring-cleaning

[bogde]

Closing this issue. @karesztrk, feel free to open it again if you still have any problems or want to provide any feedback.